FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Build System

 
 
LinkBack Thread Tools
 
Old 03-30-2011, 05:17 AM
Anthony Towns
 
Default Custom headers/footers in koji

Hello world,

Attached is a couple of small additions to koji's web code to allow customising the headers/footer a little more (headers are good to customise for linking back to the main site or secondary koji instances; footers are good to customise for web analytics

The approach I'm using is just to allow the admin to add a couple of files with custom HTML that get automatically included when they're present -- it's a bit kludgy, but from what I can tell overriding the header/footer Cheetah templates more directly would require some fairly in depth changes to the way koji does templating.

Any thoughts on whether this is plausible to go in koji proper, or if there's a better way to do it?

Cheers,
aj (a newbie in Red Hat release engineering, and even newbie-er in Fedora

--
Anthony Towns <atowns@redhat.com>--
buildsys mailing list
buildsys@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/buildsys
 
Old 04-01-2011, 06:30 PM
Mike McLean
 
Default Custom headers/footers in koji

On 03/30/2011 01:17 AM, Anthony Towns wrote:
> Hello world,
>
> Attached is a couple of small additions to koji's web code to allow
> customising the headers/footer a little more (headers are good to
> customise for linking back to the main site or secondary koji
> instances; footers are good to customise for web analytics
>
> The approach I'm using is just to allow the admin to add a couple of
> files with custom HTML that get automatically included when they're
> present -- it's a bit kludgy, but from what I can tell overriding the
> header/footer Cheetah templates more directly would require some
> fairly in depth changes to the way koji does templating.
>
> Any thoughts on whether this is plausible to go in koji proper, or if
> there's a better way to do it?

I think the basic idea is sound. As you say, it is a little kludgy,
which is probably unavoidable without significant restructuring.

I'm curious about the header placement. You have it between the logo and
the search box, whereas the footer is at the very end.

I'm a little cautious about taking this just yet, since it amounts to a
configuration interface that we'd have to be careful about.

I know this particular patch grew out of web analytics needs. I'd be
interested to hear the perspectives of other Koji admins on this list.
Would this change serve your customization needs?
--
buildsys mailing list
buildsys@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/buildsys
 
Old 04-04-2011, 01:49 AM
Anthony Towns
 
Default Custom headers/footers in koji

----- Original Message -----
> From: "Mike McLean" <mikem@redhat.com>
> On 03/30/2011 01:17 AM, Anthony Towns wrote:
> > Hello world,
> > Attached is a couple of small additions to koji's web code to allow
> > customising the headers/footer a little more (headers are good to
> > customise for linking back to the main site or secondary koji
> > instances; footers are good to customise for web analytics
> I'm curious about the header placement. You have it between the logo
> and the search box, whereas the footer is at the very end.

That seemed like the best place to put additional headers -- if you wanted to add a list of kojis for secondary architectures or similar, having them between the logo and the search box seemed about right to me.

The other option would just be to have the extra header replace the logo -- if you want to keep the logo, you just add in the img code in your custom html, and then you can add stuff before or after the logo as you like.

Cheers,
aj

--
Anthony Towns <atowns@redhat.com>
--
buildsys mailing list
buildsys@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/buildsys
 

Thread Tools




All times are GMT. The time now is 06:00 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org