Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Fedora Build System (http://www.linux-archive.org/fedora-build-system/)
-   -   Do not build binary packages with --nodeps. (http://www.linux-archive.org/fedora-build-system/442325-do-not-build-binary-packages-nodeps.html)

Ville Skyttä 10-20-2010 08:04 PM

Do not build binary packages with --nodeps.
 
Not sure why it was done in the first place; maybe because of
fragility of resolvedep screen-scraping? We no longer do that.
---
py/mock/backend.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/py/mock/backend.py b/py/mock/backend.py
index 81a98d0..4ad5963 100644
--- a/py/mock/backend.py
+++ b/py/mock/backend.py
@@ -531,7 +531,7 @@ class Root(object):
self._callHooks('prebuild')

self.doChroot(
- ["bash", "--login", "-c", 'rpmbuild -bb --target %s --nodeps %s' % (self.rpmbuild_arch, chrootspec)],
+ ["bash", "--login", "-c", 'rpmbuild -bb --target %s %s' % (self.rpmbuild_arch, chrootspec)],
shell=False,
logger=self.build_log, timeout=timeout,
uid=self.chrootuid,
--
1.7.2.3

--
buildsys mailing list
buildsys@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/buildsys

Dennis Gilmore 10-21-2010 09:33 PM

Do not build binary packages with --nodeps.
 
On Wed, Oct 20, 2010 at 11:04:19PM +0300, Ville Skyttä wrote:
> Not sure why it was done in the first place; maybe because of
> fragility of resolvedep screen-scraping? We no longer do that.
> ---
> py/mock/backend.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/py/mock/backend.py b/py/mock/backend.py
> index 81a98d0..4ad5963 100644
> --- a/py/mock/backend.py
> +++ b/py/mock/backend.py
> @@ -531,7 +531,7 @@ class Root(object):
> self._callHooks('prebuild')
>
> self.doChroot(
> - ["bash", "--login", "-c", 'rpmbuild -bb --target %s --nodeps %s' % (self.rpmbuild_arch, chrootspec)],
> + ["bash", "--login", "-c", 'rpmbuild -bb --target %s %s' % (self.rpmbuild_arch, chrootspec)],
> shell=False,
> logger=self.build_log, timeout=timeout,
> uid=self.chrootuid,
> --
> 1.7.2.3

its done because you cant trust that the rpm in the chroot can access
the rpm database that was created by the hosts rpm.

-1 to this patch

Dennis
--
buildsys mailing list
buildsys@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/buildsys

Ville Skyttä 10-22-2010 04:40 PM

Do not build binary packages with --nodeps.
 
On Friday 22 October 2010, Dennis Gilmore wrote:
> On Wed, Oct 20, 2010 at 11:04:19PM +0300, Ville Skyttä wrote:
> > Not sure why it was done in the first place; maybe because of
> > fragility of resolvedep screen-scraping? We no longer do that.
> > ---
[...]
>
> its done because you cant trust that the rpm in the chroot can access
> the rpm database that was created by the hosts rpm.

Thank you. Patch withdrawn, and a comment explaining the reason committed
instead.
--
buildsys mailing list
buildsys@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/buildsys


All times are GMT. The time now is 06:35 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.