FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Build System

 
 
LinkBack Thread Tools
 
Old 09-16-2008, 05:48 PM
"Brian Edginton"
 
Default A couple of questions about pungi

On Tue, Sep 16, 2008 at 11:28 AM, Jesse Keating
<jkeating@j2solutions.net> wrote:
> On Tue, 2008-09-16 at 11:22 -0600, Brian Edginton wrote:
>>
>> 1) With the advent of using a kickstart and/or command lines I cannot
>> find a way to set iso_basename which defaults to "Fedora"
>
> Have you used the --name option? That's what defaults to Fedora.

Yes, I have. That set's the product and release information as it
traverses through correctly but doesn't effect the name of the iso,
which is built from a concatenation of iso_basename, version and arch
(pungi.py). In config.py iso_basename is defaulted to 'Fedora' but it
seems there is no practical way to set it from a config or cli. It
looks like some older turn of pungi set iso_basename to name if it was
empty but that has gone away now.

-edge

--
Fedora-buildsys-list mailing list
Fedora-buildsys-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-buildsys-list
 
Old 09-16-2008, 05:56 PM
Jesse Keating
 
Default A couple of questions about pungi

On Tue, 2008-09-16 at 11:48 -0600, Brian Edginton wrote:
> Yes, I have. That set's the product and release information as it
> traverses through correctly but doesn't effect the name of the iso,
> which is built from a concatenation of iso_basename, version and arch
> (pungi.py). In config.py iso_basename is defaulted to 'Fedora' but it
> seems there is no practical way to set it from a config or cli. It
> looks like some older turn of pungi set iso_basename to name if it was
> empty but that has gone away now.

Hrm, ok. I know I lost some things when we moved away from a config
file. I don't think it's all that unreasonable to set an iso basename
to that of name, I'll take a look (or review a patch...

--
Jesse Keating
Fedora -- Freedom˛ is a feature!
identi.ca: http://identi.ca/jkeating
--
Fedora-buildsys-list mailing list
Fedora-buildsys-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-buildsys-list
 
Old 09-16-2008, 06:01 PM
"Brian Edginton"
 
Default A couple of questions about pungi

On Tue, Sep 16, 2008 at 11:56 AM, Jesse Keating <jkeating@redhat.com> wrote:
> On Tue, 2008-09-16 at 11:48 -0600, Brian Edginton wrote:
>> Yes, I have. That set's the product and release information as it
>> traverses through correctly but doesn't effect the name of the iso,
>> which is built from a concatenation of iso_basename, version and arch
>> (pungi.py). In config.py iso_basename is defaulted to 'Fedora' but it
>> seems there is no practical way to set it from a config or cli. It
>> looks like some older turn of pungi set iso_basename to name if it was
>> empty but that has gone away now.
>
> Hrm, ok. I know I lost some things when we moved away from a config
> file. I don't think it's all that unreasonable to set an iso basename
> to that of name, I'll take a look (or review a patch...

Hint taken. Let me review it a bit more and I'll get something to you.

-edge

--
Fedora-buildsys-list mailing list
Fedora-buildsys-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-buildsys-list
 
Old 09-18-2008, 03:49 PM
"Brian Edginton"
 
Default A couple of questions about pungi

On Tue, Sep 16, 2008 at 12:01 PM, Brian Edginton <edge@edginton.net> wrote:
> On Tue, Sep 16, 2008 at 11:56 AM, Jesse Keating <jkeating@redhat.com> wrote:
>> On Tue, 2008-09-16 at 11:48 -0600, Brian Edginton wrote:
>>> Yes, I have. That set's the product and release information as it
>>> traverses through correctly but doesn't effect the name of the iso,
>>> which is built from a concatenation of iso_basename, version and arch
>>> (pungi.py). In config.py iso_basename is defaulted to 'Fedora' but it
>>> seems there is no practical way to set it from a config or cli. It
>>> looks like some older turn of pungi set iso_basename to name if it was
>>> empty but that has gone away now.
>>
>> Hrm, ok. I know I lost some things when we moved away from a config
>> file. I don't think it's all that unreasonable to set an iso basename
>> to that of name, I'll take a look (or review a patch...
>
> Hint taken. Let me review it a bit more and I'll get something to you.
>
> -edge
>

<disclaimer python'eer=not>

So, I would have expected the following change to have the effect of
setting iso_basename to 'name'.

config.py

-self.set('default', 'iso_basename', 'Fedora')
+self.set('default', 'iso_basename', self.get('default', 'name'))

but what I find is that it sets iso_basename to the default value of
'name' even when 'name' has been set to another string. I can see this
because the value I set it to is actually reflected in the options
passed to the various utils that pungi calls. It is almost like
iso_basename is being evaluated before name. Is there an inherent
order that the members are instantiated in python?

What am I missing here?

-edge

--
Fedora-buildsys-list mailing list
Fedora-buildsys-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-buildsys-list
 

Thread Tools




All times are GMT. The time now is 04:19 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org