Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   EXT3 Users (http://www.linux-archive.org/ext3-users/)
-   -   Fix creation of encrypted md members and pvs in kickstart. (#567396) (http://www.linux-archive.org/ext3-users/330400-fix-creation-encrypted-md-members-pvs-kickstart-567396-a.html)

Chris Lumens 02-22-2010 09:22 PM

Fix creation of encrypted md members and pvs in kickstart. (#567396)
 
> diff --git a/kickstart.py b/kickstart.py
> index 64e372d..8ae80f5 100644
> --- a/kickstart.py
> +++ b/kickstart.py
> @@ -831,6 +831,11 @@ class RaidData(commands.raid.F12_RaidData):
> # if member is using --onpart, use original device
> member = anaconda.ksdata.onPart.get(member, member)
> dev = devicetree.getDeviceByName(member)
> + if dev.format.type == "luks":
> + try:
> + dev = devicetree.getChildren(dev)[0]
> + except IndexError:
> + dev = None
> if not dev:
> raise KickstartValueError, formatErrorMsg(self.lineno, msg="Tried to use undefined partition %s in RAID specification" % member)
>

The existing code checked that devicetree.getDeviceByName returned
something valid before going on. You'll need to do some restructuring
here to keep that check as well as checking the result after
devicetree.getChildren too.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Chris Lumens 02-22-2010 09:57 PM

Fix creation of encrypted md members and pvs in kickstart. (#567396)
 
> kickstart.py | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)

Ship it.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 11:38 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.