FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Enterprise Watch List

 
 
LinkBack Thread Tools
 
Old 11-02-2011, 09:43 PM
"Brian C. Lane"
 
Default If no AP is selected don't write config files (#750896)

From: "Brian C. Lane" <bcl@redhat.com>

When the user cancels the SSID dialog we should not be writing
any config files. Previously we would write config files for all
of the seen AP's, any of which may belong to Eve.
---
pyanaconda/gui.py | 2 +-
pyanaconda/network.py | 3 +++
2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/pyanaconda/gui.py b/pyanaconda/gui.py
index a1d8613..e6fad4b 100755
--- a/pyanaconda/gui.py
+++ b/pyanaconda/gui.py
@@ -937,7 +937,7 @@ class InstallInterface(InstallInterfaceBase):
dev_all_ssids = self.anaconda.network.getSSIDs()
w.pop()
# select wireless APs
- dev_ssids = selectSSIDsDialog(dev_all_ssids) or dev_all_ssids
+ dev_ssids = selectSSIDsDialog(dev_all_ssids)
self.anaconda.network.writeSSIDifcfgs(dev_ssids)

self.anaconda.network.writeIfcfgFiles()
diff --git a/pyanaconda/network.py b/pyanaconda/network.py
index 581ea72..4e64684 100644
--- a/pyanaconda/network.py
+++ b/pyanaconda/network.py
@@ -574,6 +574,9 @@ class Network:
return ifaces

def writeSSIDifcfgs(self, devssids):
+ if not devssids:
+ return
+
ssids = []
for ssidlist in devssids.values():
ssids.extend(ssidlist)
--
1.7.6.4

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 11-02-2011, 10:45 PM
David Lehman
 
Default If no AP is selected don't write config files (#750896)

On Wed, 2011-11-02 at 15:43 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl@redhat.com>
>
> When the user cancels the SSID dialog we should not be writing
> any config files. Previously we would write config files for all
> of the seen AP's, any of which may belong to Eve.

Ack.

> ---
> pyanaconda/gui.py | 2 +-
> pyanaconda/network.py | 3 +++
> 2 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/pyanaconda/gui.py b/pyanaconda/gui.py
> index a1d8613..e6fad4b 100755
> --- a/pyanaconda/gui.py
> +++ b/pyanaconda/gui.py
> @@ -937,7 +937,7 @@ class InstallInterface(InstallInterfaceBase):
> dev_all_ssids = self.anaconda.network.getSSIDs()
> w.pop()
> # select wireless APs
> - dev_ssids = selectSSIDsDialog(dev_all_ssids) or dev_all_ssids
> + dev_ssids = selectSSIDsDialog(dev_all_ssids)
> self.anaconda.network.writeSSIDifcfgs(dev_ssids)
>
> self.anaconda.network.writeIfcfgFiles()
> diff --git a/pyanaconda/network.py b/pyanaconda/network.py
> index 581ea72..4e64684 100644
> --- a/pyanaconda/network.py
> +++ b/pyanaconda/network.py
> @@ -574,6 +574,9 @@ class Network:
> return ifaces
>
> def writeSSIDifcfgs(self, devssids):
> + if not devssids:
> + return
> +
> ssids = []
> for ssidlist in devssids.values():
> ssids.extend(ssidlist)


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 09:42 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org