FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Edubuntu User

 
 
LinkBack Thread Tools
 
Old 09-06-2011, 12:02 PM
Ales Kozumplik
 
Default Don't skip biosboot request if no stage1_drive has been chosen.

Otherwise bootloader.stage1_device() later will not detect any suitable
devices because it will find we're using a GPT disk with no biosboot
partitions. That fails sanityCheck().

Resolves: rhbz#734861
---
pyanaconda/storage/partitioning.py | 27 ++++++++++++++-------------
1 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/pyanaconda/storage/partitioning.py b/pyanaconda/storage/partitioning.py
index 237e55e..601fa58 100644
--- a/pyanaconda/storage/partitioning.py
+++ b/pyanaconda/storage/partitioning.py
@@ -134,19 +134,20 @@ def _schedulePartitions(storage, disks):
continue
elif request.fstype == "biosboot" and storage.anaconda:
boot_disk = storage.anaconda.bootloader.stage1_drive
- if boot_disk and boot_disk.format.labelType != "gpt":
- # biosboot is only needed for gpt disklabels on non-efi x86
- log.info("skipping bios boot request for msdos disklabel")
- log.debug(request)
- continue
+ if boot_disk:
+ if boot_disk.format.labelType != "gpt":
+ # biosboot is only needed for gpt disklabels on non-efi x86
+ log.info("skipping bios boot request for msdos disklabel")
+ log.debug(request)
+ continue

- gpt_check = getattr(storage.anaconda.bootloader,
- "_gpt_disk_has_bios_boot",
- None)
- if gpt_check and gpt_check(boot_disk):
- # there's already a bios boot partition on the gpt boot disk
- log.info("skipping bios boot request since boot disk has one")
- continue
+ gpt_check = getattr(storage.anaconda.bootloader,
+ "_gpt_disk_has_bios_boot",
+ None)
+ if gpt_check and gpt_check(boot_disk):
+ # there's already a bios boot partition on the gpt boot disk
+ log.info("skipping bios boot request since boot disk has one")
+ continue

# This is a little unfortunate but let the backend dictate the rootfstype
# so that things like live installs can do the right thing
--
1.7.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 09-06-2011, 12:08 PM
Ales Kozumplik
 
Default Don't skip biosboot request if no stage1_drive has been chosen.

On 09/06/2011 02:02 PM, Ales Kozumplik wrote:

Otherwise bootloader.stage1_device() later will not detect any suitable
devices because it will find we're using a GPT disk with no biosboot
partitions. That fails sanityCheck().

Resolves: rhbz#734861


This needs a good review, I used this bug to learn about bootloader.py a
bit.


I was hitting the problem on a KVM (non-efi) machine. Autopartitioning
in the UI now shows bios boot partition scheduled for creation as expected:


http://akozumpl.fedorapeople.org/biosboot.png

Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 04:44 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org