FAQ Search Today's Posts Mark Forums Read

» Linux Archive
Home
New Posts
Search
FAQ



 
 
LinkBack Thread Tools
 
Old 04-30-2008, 10:04 AM
 
Default Fixup Makefiles

We're now using dlopen() etc, so we should link to libdl
explicitely instead of relying on some other library to do
this for us.
And '-fPIC' is a mandatory CFLAGS setting now, not an
optimisation.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
Makefile.inc | 4 ++--
multipath/Makefile | 2 +-
multipathd/Makefile | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Makefile.inc b/Makefile.inc
index 622f557..3e5bca0 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -26,8 +26,8 @@ libdir = $(prefix)/lib/multipath
GZIP = /bin/gzip -9 -c
INSTALL_PROGRAM = install

-OPTFLAGS = -pipe -g -Wall -Wunused -Wstrict-prototypes -fPIC
-CFLAGS = $(OPTFLAGS)
+OPTFLAGS = -pipe -g -Wall -Wunused -Wstrict-prototypes
+CFLAGS = $(OPTFLAGS) -fPIC
SHARED_FLAGS = -shared

%.o: %.c
diff --git a/multipath/Makefile b/multipath/Makefile
index 71df431..2d74ffe 100644
--- a/multipath/Makefile
+++ b/multipath/Makefile
@@ -7,7 +7,7 @@ include ../Makefile.inc
OBJS = main.o

CFLAGS += -I$(multipathdir) -Wl,-rpath,$(libdir)
-LDFLAGS += -laio -ldevmapper -lpthread
+LDFLAGS += -lpthread -ldevmapper -laio -ldl
-lmultipath -L$(multipathdir)

EXEC = multipath
diff --git a/multipathd/Makefile b/multipathd/Makefile
index dd223c4..b1af76c 100644
--- a/multipathd/Makefile
+++ b/multipathd/Makefile
@@ -6,7 +6,7 @@ include ../Makefile.inc
# basic flags setting
#
CFLAGS += -I$(multipathdir) -Wl,-rpath,$(libdir)
-LDFLAGS += -lpthread -ldevmapper -lreadline -lncurses -laio
+LDFLAGS += -lpthread -ldevmapper -lreadline -lncurses -laio -ldl
-lmultipath -L$(multipathdir)

#
--
1.5.2.4

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 03:35 AM.

VBulletin, Copyright ©2000 - 2009, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org