Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Device-mapper Development (http://www.linux-archive.org/device-mapper-development/)
-   -   multipath-tools: fix the bug while processing vpd 0x83 designation descriptors (http://www.linux-archive.org/device-mapper-development/636283-multipath-tools-fix-bug-while-processing-vpd-0x83-designation-descriptors.html)

"Moger, Babu" 02-22-2012 05:09 PM

multipath-tools: fix the bug while processing vpd 0x83 designation descriptors
 
This patch fixes the bug while processing the vpd 0x83 designation descriptors.
Removing the buggy check(> sizeof(buf))while loping the descriptors. Sizeof(buf) will
always return 8 (in 64 bit machine). Descriptor length can be more than 8 bytes in
some cases. This was causing problems while configuring my storage with alua.

Signed-off-by: Babu Moger <babu.moger@netapp.com>
---
--- multipath-tools/libmultipath/prioritizers/alua_rtpg.c.orig 2012-02-21 16:14:55.000000000 -0600
+++ multipath-tools/libmultipath/prioritizers/alua_rtpg.c 2012-02-21 16:16:41.000000000 -0600
@@ -184,9 +184,6 @@ get_target_port_group(int fd)

rc = -RTPG_NO_TPG_IDENTIFIER;
FOR_EACH_VPD83_DSCR(vpd83, dscr) {
- if ((((char *) dscr) - ((char *) vpd83)) > sizeof(buf))
- break;
-
if (vpd83_dscr_istype(dscr, IDTYPE_TARGET_PORT_GROUP)) {
struct vpd83_tpg_dscr * p;




--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


All times are GMT. The time now is 03:03 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.