FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 01-09-2012, 02:08 AM
Phillip Susi
 
Default Don't add 'p' delimiter when you shouldn't

The 'p' delimiter is supposed to be added when the base disk name
ends in a digit. This decision was based on the name given on the
command line, not the canonical device name, so giving /dev/dm-0
instead of /dev/mapper/foo triggered the digit test and added the
'p'. Changed test to use the canonical name rather than the given
name.

Index: b/kpartx/kpartx.c
================================================== =================
--- a/kpartx/kpartx.c
+++ b/kpartx/kpartx.c
@@ -310,12 +310,6 @@
device = loopdev;
}

- if (delim == NULL) {
- delim = malloc(DELIM_SIZE);
- memset(delim, 0, DELIM_SIZE);
- set_delimiter(device, delim);
- }
-
off = find_devname_offset(device);

if (!loopdev) {
@@ -331,6 +325,12 @@
if (!mapname)
mapname = device + off;

+ if (delim == NULL) {
+ delim = malloc(DELIM_SIZE);
+ memset(delim, 0, DELIM_SIZE);
+ set_delimiter(mapname, delim);
+ }
+
fd = open(device, O_RDONLY);

if (fd == -1) {

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 02-09-2012, 06:33 PM
Phillip Susi
 
Default Don't add 'p' delimiter when you shouldn't

Not heard anything back about this yet. Does anyone have any comments
or care to merge it?

On 1/8/2012 10:08 PM, Phillip Susi wrote:
> The 'p' delimiter is supposed to be added when the base disk name
> ends in a digit. This decision was based on the name given on the
> command line, not the canonical device name, so giving /dev/dm-0
> instead of /dev/mapper/foo triggered the digit test and added the
> 'p'. Changed test to use the canonical name rather than the given
> name.
>
> Index: b/kpartx/kpartx.c
> ================================================== =================
> --- a/kpartx/kpartx.c
> +++ b/kpartx/kpartx.c
> @@ -310,12 +310,6 @@
> device = loopdev;
> }
>
> - if (delim == NULL) {
> - delim = malloc(DELIM_SIZE);
> - memset(delim, 0, DELIM_SIZE);
> - set_delimiter(device, delim);
> - }
> -
> off = find_devname_offset(device);
>
> if (!loopdev) {
> @@ -331,6 +325,12 @@
> if (!mapname)
> mapname = device + off;
>
> + if (delim == NULL) {
> + delim = malloc(DELIM_SIZE);
> + memset(delim, 0, DELIM_SIZE);
> + set_delimiter(mapname, delim);
> + }
> +
> fd = open(device, O_RDONLY);
>
> if (fd == -1) {
>
>
>
>
> --

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 02-09-2012, 07:17 PM
Christophe Varoqui
 
Default Don't add 'p' delimiter when you shouldn't

On dim., 2012-01-08 at 22:08 -0500, Phillip Susi wrote:
> The 'p' delimiter is supposed to be added when the base disk name
> ends in a digit. This decision was based on the name given on the
> command line, not the canonical device name, so giving /dev/dm-0
> instead of /dev/mapper/foo triggered the digit test and added the
> 'p'. Changed test to use the canonical name rather than the given
> name.

Rebased and merged.

Thanks.

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Thu Feb 9 22:30:01 2012
Return-path: <bounce-debian-dpkg=tom=linux-archive.org@lists.debian.org>
Envelope-to: tom@linux-archive.org
Delivery-date: Thu, 09 Feb 2012 22:20:40 +0200
Received: from liszt.debian.org ([82.195.75.100]:34603)
by s2.java-tips.org with esmtps (TLSv1:AES256-SHA:256)
(Exim 4.69)
(envelope-from <bounce-debian-dpkg=tom=linux-archive.org@lists.debian.org>)
id 1RvaTw-0006Dn-A0
for tom@linux-archive.org; Thu, 09 Feb 2012 22:20:40 +0200
Received: from localhost (localhost [127.0.0.1])
by liszt.debian.org (Postfix) with QMQP
id 2997013A48D9; Thu, 9 Feb 2012 20:21:12 +0000 (UTC)
Old-Return-Path: <mellissa.rowe@sitesalesspecialists.com>
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on liszt.debian.org
X-Spam-Level: **
X-Spam-Status: No, score=2.0 required=4.0 tests=MDO_CABLE_TV3,MONEY,
RAZOR2_CHECK autolearn=no version=3.2.5
X-Original-To: lists-debian-dpkg@liszt.debian.org
Delivered-To: lists-debian-dpkg@liszt.debian.org
Received: from localhost (localhost [127.0.0.1])
by liszt.debian.org (Postfix) with ESMTP id 7971A13A47F2
for <lists-debian-dpkg@liszt.debian.org>; Thu, 9 Feb 2012 20:04:56 +0000 (UTC)
X-Virus-Scanned: at lists.debian.org with policy bank en-lt
X-Amavis-Spam-Status: No, score=2 tagged_above=-10000 required=5.3
tests=[MDO_CABLE_TV3=0.5, MONEY=0.5, RAZOR2_CHECK=1] autolearn=no
Received: from liszt.debian.org ([127.0.0.1])
by localhost (lists.debian.org [127.0.0.1]) (amavisd-new, port 2525)
with ESMTP id v4PkO-67kDjV for <lists-debian-dpkg@liszt.debian.org>;
Thu, 9 Feb 2012 20:04:46 +0000 (UTC)
X-policyd-weight: using cached result; rate:hard: -4.2
X-Greylist: delayed 2717 seconds by postgrey-1.31 at liszt; Thu, 09 Feb 2012 20:04:46 UTC
Received: from gmu.globalmarketlinkbuilding.org (www.globalmarketingbacklinking.org [200.107.238.220])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client did not present a certificate)
by liszt.debian.org (Postfix) with ESMTPS id 39F0713A47A4
for <debian-dpkg@lists.debian.org>; Thu, 9 Feb 2012 20:04:46 +0000 (UTC)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=sitesalesspecialists.com;
h=Received:MIME-Version:From:To:Reply-Toate:Subject:Content-Type:Content-Transfer-Encoding;
b=xy1Sk5Dd0zj0n0yA538XaVPTzUMGKD9j92jci8nDqFZ12DA3 uGJIuTcqKO32lXvO1NpU5X3n43ez1u+h27MBr2P+Q8UFwc8NGY 6G+arKBIbsPbpXvKo9ygob5AJwjRGg;
Received: from [200.107.238.232] (helo=KEVIN-PC)
by gmu.globalmarketlinkbuilding.org with esmtpa (Exim 4.69)
(envelope-from <mellissa.rowe@sitesalesspecialists.com>)
id 1RvZWC-0006Vs-Ca
for debian-dpkg@lists.debian.org; Thu, 09 Feb 2012 13:18:56 -0600
MIME-Version: 1.0
From: "Mellissa Rowe"
<mellissa.rowe@sitesalesspecialists.com>
To: debian-dpkg@lists.debian.org
Reply-To: "Mellissa Rowe"
<mellissa.rowe@sitesalesspecialists.com>
Date: 9 Feb 2012 13:19:10 -0600
Subject: raphaelhertzog.com Acquisition
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - gmu.globalmarketlinkbuilding.org
X-AntiAbuse: Original Domain - lists.debian.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - sitesalesspecialists.com
Message-Id: <20120209200446.39F0713A47A4@liszt.debian.org>
X-Rc-Spam: 2008-11-04_01
X-Rc-Virus: 2007-09-13_01
X-Rc-Spam: 2008-11-04_01
Resent-Message-ID: <nJY-KZSIKQE.A.2hE.4qCNPB@liszt>
Resent-From: debian-dpkg@lists.debian.org
X-Mailing-List: <debian-dpkg@lists.debian.org> archive/latest/17177
X-Loop: debian-dpkg@lists.debian.org
List-Id: <debian-dpkg.lists.debian.org>
List-Post: <mailto:debian-dpkg@lists.debian.org>
List-Help: <mailto:debian-dpkg-request@lists.debian.org?subject=help>
List-Subscribe: <mailto:debian-dpkg-request@lists.debian.org?subject=subscribe>
List-Unsubscribe: <mailto:debian-dpkg-request@lists.debian.org?subject=unsubscribe>
Precedence: list
Resent-Sender: debian-dpkg-request@lists.debian.org
Resent-Date: Thu, 9 Feb 2012 20:21:12 +0000 (UTC)

We are representing a venture capital firm located in Silicon Val=
ley=0D=0Aand would like to open up discussions about the possible=
acquisition=0D=0Aof raphaelhertzog.com.=0D=0A=0D=0AThey are inte=
rested in acquiring businesses in this niche that have=0D=0Areven=
ues above $150k per year or have traffic over 100k unique=0D=0Avi=
sitors per month.=0D=0A=0D=0AOffers are usually at multiples of t=
railing earnings, however, some=0D=0Adeals are based on brand, us=
er base, and traffic.=0D=0A=0D=0AIf interested in entertaining an=
offer, please provide us with some=0D=0Ahistory of the online bu=
siness and best time to reach you.=0D=0A=0D=0A=0D=0ABest Regards,=
=0D=0A=0D=0AMellissa Rowe=0D=0Amellissa.rowe@sitesalesspecialists=
.com=0D=0AAcquisition Team Lead=0D=0APhoenix, Arizona=0D=0A=0D=0A=
=0D=0A=0D=0A =0D=0A =0D=0A =0D=0A =0D=0A=0D=0A=0D=0A=0D=0A=0D=0A=0D=0A=
=0D=0AThis email complies with all current applicable laws under =
the =0D=0ACAN Act of 2003. Your site was manually compiled from =
public =0D=0Aecords available online. If you don't want to recei=
ve anything from =0D=0Aus in the future, just click this:=0D=0A=0D=0A=
http://www.sitesalesspecialists.com/quit.php?emailid=3D3984398208=
5398&unsubscribe=3Dtrue


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: http://lists.debian.org/20120209200446.39F0713A47A4@liszt.debian.org


Thu Feb 9 22:30:01 2012
Return-path: <bounce-debian-devel=tom=linux-archive.org@lists.debian.org>
Envelope-to: tom@linux-archive.org
Delivery-date: Thu, 09 Feb 2012 22:20:47 +0200
Received: from liszt.debian.org ([82.195.75.100]:35827)
by s2.java-tips.org with esmtps (TLSv1:AES256-SHA:256)
(Exim 4.69)
(envelope-from <bounce-debian-devel=tom=linux-archive.org@lists.debian.org>)
id 1RvaU3-0006Ds-9y
for tom@linux-archive.org; Thu, 09 Feb 2012 22:20:47 +0200
Received: from localhost (localhost [127.0.0.1])
by liszt.debian.org (Postfix) with QMQP
id 4E7A313A48D3; Thu, 9 Feb 2012 20:21:09 +0000 (UTC)
Old-Return-Path: <mellissa.rowe@sitesalesspecialists.com>
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on liszt.debian.org
X-Spam-Level: **
X-Spam-Status: No, score=2.0 required=4.0 tests=MDO_CABLE_TV3,MONEY,
RAZOR2_CHECK autolearn=no version=3.2.5
X-Original-To: lists-debian-devel@liszt.debian.org
Delivered-To: lists-debian-devel@liszt.debian.org
Received: from localhost (localhost [127.0.0.1])
by liszt.debian.org (Postfix) with ESMTP id 6C43413A47F2
for <lists-debian-devel@liszt.debian.org>; Thu, 9 Feb 2012 20:04:49 +0000 (UTC)
X-Virus-Scanned: at lists.debian.org with policy bank en-ht
X-Amavis-Spam-Status: No, score=2 tagged_above=-10000 required=5.3
tests=[MDO_CABLE_TV3=0.5, MONEY=0.5, RAZOR2_CHECK=1] autolearn=no
Received: from liszt.debian.org ([127.0.0.1])
by localhost (lists.debian.org [127.0.0.1]) (amavisd-new, port 2525)
with ESMTP id rWpDcI5cKRVm for <lists-debian-devel@liszt.debian.org>;
Thu, 9 Feb 2012 20:04:42 +0000 (UTC)
X-policyd-weight: using cached result; rate:hard: -4.2
X-Greylist: delayed 2713 seconds by postgrey-1.31 at liszt; Thu, 09 Feb 2012 20:04:42 UTC
Received: from gmu.globalmarketlinkbuilding.org (www.globalmarketingbacklinking.org [200.107.238.220])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client did not present a certificate)
by liszt.debian.org (Postfix) with ESMTPS id 667FF13A46C3
for <debian-devel@lists.debian.org>; Thu, 9 Feb 2012 20:04:42 +0000 (UTC)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=sitesalesspecialists.com;
h=Received:MIME-Version:From:To:Reply-Toate:Subject:Content-Type:Content-Transfer-Encoding;
b=ucd/MkOOJnv3it+Wa5LPIQYxyGYgNjnDXoG0wv2ahi3VIv1XRnbKsR aaGNCjfYC/eaohyIeJ/TOfc9BR2iGD8rOpbjHlvv73DqPi3mq1ZcYE2g/2fYQaw3pEVzY+IJT4;
Received: from [200.107.238.232] (helo=KEVIN-PC)
by gmu.globalmarketlinkbuilding.org with esmtpa (Exim 4.69)
(envelope-from <mellissa.rowe@sitesalesspecialists.com>)
id 1RvZWC-0006Vv-DP
for debian-devel@lists.debian.org; Thu, 09 Feb 2012 13:18:56 -0600
MIME-Version: 1.0
From: "Mellissa Rowe"
<mellissa.rowe@sitesalesspecialists.com>
To: debian-devel@lists.debian.org
Reply-To: "Mellissa Rowe"
<mellissa.rowe@sitesalesspecialists.com>
Date: 9 Feb 2012 13:19:10 -0600
Subject: raphaelhertzog.com Acquisition
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - gmu.globalmarketlinkbuilding.org
X-AntiAbuse: Original Domain - lists.debian.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - sitesalesspecialists.com
Message-Id: <20120209200442.667FF13A46C3@liszt.debian.org>
X-Rc-Spam: 2008-11-04_01
X-Rc-Virus: 2007-09-13_01
X-Rc-Spam: 2008-11-04_01
Resent-Message-ID: <8zgTOx_2yUO.A.0cE.1qCNPB@liszt>
Resent-From: debian-devel@lists.debian.org
X-Mailing-List: <debian-devel@lists.debian.org> archive/latest/279549
X-Loop: debian-devel@lists.debian.org
List-Id: <debian-devel.lists.debian.org>
List-Post: <mailto:debian-devel@lists.debian.org>
List-Help: <mailto:debian-devel-request@lists.debian.org?subject=help>
List-Subscribe: <mailto:debian-devel-request@lists.debian.org?subject=subscribe>
List-Unsubscribe: <mailto:debian-devel-request@lists.debian.org?subject=unsubscribe>
Precedence: list
Resent-Sender: debian-devel-request@lists.debian.org
Resent-Date: Thu, 9 Feb 2012 20:21:09 +0000 (UTC)

We are representing a venture capital firm located in Silicon Val=
ley=0D=0Aand would like to open up discussions about the possible=
acquisition=0D=0Aof raphaelhertzog.com.=0D=0A=0D=0AThey are inte=
rested in acquiring businesses in this niche that have=0D=0Areven=
ues above $150k per year or have traffic over 100k unique=0D=0Avi=
sitors per month.=0D=0A=0D=0AOffers are usually at multiples of t=
railing earnings, however, some=0D=0Adeals are based on brand, us=
er base, and traffic.=0D=0A=0D=0AIf interested in entertaining an=
offer, please provide us with some=0D=0Ahistory of the online bu=
siness and best time to reach you.=0D=0A=0D=0A=0D=0ABest Regards,=
=0D=0A=0D=0AMellissa Rowe=0D=0Amellissa.rowe@sitesalesspecialists=
.com=0D=0AAcquisition Team Lead=0D=0APhoenix, Arizona=0D=0A=0D=0A=
=0D=0A=0D=0A =0D=0A =0D=0A =0D=0A =0D=0A=0D=0A=0D=0A=0D=0A=0D=0A=0D=0A=
=0D=0AThis email complies with all current applicable laws under =
the =0D=0ACAN Act of 2003. Your site was manually compiled from =
public =0D=0Aecords available online. If you don't want to recei=
ve anything from =0D=0Aus in the future, just click this:=0D=0A=0D=0A=
http://www.sitesalesspecialists.com/quit.php?emailid=3D3984398208=
5398&unsubscribe=3Dtrue


--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: http://lists.debian.org/20120209200442.667FF13A46C3@liszt.debian.org
 

Thread Tools




All times are GMT. The time now is 10:53 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org