Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Device-mapper Development (http://www.linux-archive.org/device-mapper-development/)
-   -   multipath-tools: Remove bad udev rules (http://www.linux-archive.org/device-mapper-development/607077-multipath-tools-remove-bad-udev-rules.html)

Phillip Susi 12-06-2011 03:12 PM

multipath-tools: Remove bad udev rules
 
This sample udev rules file contains some rules relating to dmraid
that both should not be there and are broken anyhow. They should
not be there because firstly, what is a dmraid rule doing in a
kpartx rule file, and secondly, dmraid already activates partitions
itself, so there is no need to run kpartx to do that. The rule is
broken because it is matching on the DM_UUID starting with "dmraid-",
but this comparison is case sensitive, and it actually starts with
"DMRAID-".

Signed-off-by: Phillip Susi <psusi@cfl.rr.com>
---
kpartx/kpartx.rules | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/kpartx/kpartx.rules b/kpartx/kpartx.rules
index 4c23dec..64863a0 100644
--- a/kpartx/kpartx.rules
+++ b/kpartx/kpartx.rules
@@ -17,10 +17,6 @@ OPTIONS="link_priority=50"
ENV{DM_UUID}=="mpath-*",
SYMLINK+="disk/by-id/$env{DM_TYPE}-$env{DM_NAME}"

-# Create persistent links for dmraid tables
-ENV{DM_UUID}=="dmraid-*",
- SYMLINK+="disk/by-id/$env{DM_TYPE}-$env{DM_NAME}"
-
# Create persistent links for partitions
ENV{DM_PART}=="?*",
SYMLINK+="disk/by-id/$env{DM_TYPE}-$env{DM_NAME}-part$env{DM_PART}"
@@ -28,8 +24,6 @@ ENV{DM_PART}=="?*",
# Create dm tables for partitions
ENV{DM_STATE}=="ACTIVE", ENV{DM_UUID}=="mpath-*",
RUN+="/sbin/kpartx -u -p -part /dev/$name"
-ENV{DM_STATE}=="ACTIVE", ENV{DM_UUID}=="dmraid-*",
- RUN+="/sbin/kpartx -u -p -part /dev/$name"

LABEL="kpartx_end"

--
1.7.5.4

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Christophe Varoqui 12-06-2011 09:27 PM

multipath-tools: Remove bad udev rules
 
On mar., 2011-12-06 at 11:12 -0500, Phillip Susi wrote:
> This sample udev rules file contains some rules relating to dmraid
> that both should not be there and are broken anyhow. They should
> not be there because firstly, what is a dmraid rule doing in a
> kpartx rule file, and secondly, dmraid already activates partitions
> itself, so there is no need to run kpartx to do that. The rule is
> broken because it is matching on the DM_UUID starting with "dmraid-",
> but this comparison is case sensitive, and it actually starts with
> "DMRAID-".
>
> Signed-off-by: Phillip Susi <psusi@cfl.rr.com>
> ---
> kpartx/kpartx.rules | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/kpartx/kpartx.rules b/kpartx/kpartx.rules
> index 4c23dec..64863a0 100644
> --- a/kpartx/kpartx.rules
> +++ b/kpartx/kpartx.rules
> @@ -17,10 +17,6 @@ OPTIONS="link_priority=50"
> ENV{DM_UUID}=="mpath-*",
> SYMLINK+="disk/by-id/$env{DM_TYPE}-$env{DM_NAME}"
>
> -# Create persistent links for dmraid tables
> -ENV{DM_UUID}=="dmraid-*",
> - SYMLINK+="disk/by-id/$env{DM_TYPE}-$env{DM_NAME}"
> -
> # Create persistent links for partitions
> ENV{DM_PART}=="?*",
> SYMLINK+="disk/by-id/$env{DM_TYPE}-$env{DM_NAME}-part$env{DM_PART}"
> @@ -28,8 +24,6 @@ ENV{DM_PART}=="?*",
> # Create dm tables for partitions
> ENV{DM_STATE}=="ACTIVE", ENV{DM_UUID}=="mpath-*",
> RUN+="/sbin/kpartx -u -p -part /dev/$name"
> -ENV{DM_STATE}=="ACTIVE", ENV{DM_UUID}=="dmraid-*",
> - RUN+="/sbin/kpartx -u -p -part /dev/$name"
>
> LABEL="kpartx_end"
>
Merged.


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


All times are GMT. The time now is 09:40 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.