FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 11-30-2011, 10:20 PM
"Moger, Babu"
 
Default scsi_dh: code cleanup and remove the references to scsi_dev_info

> -----Original Message-----
> From: Mike Snitzer [mailto:snitzer@redhat.com]
> Sent: Wednesday, November 30, 2011 4:52 PM
> To: Moger, Babu
> Cc: Linux SCSI Mailing list; device-mapper development; hare@suse.de
> Subject: Re: [RESEND][PATCH 4/4] scsi_dh: code cleanup and remove the
> references to scsi_dev_info
>
> On Thu, Nov 03 2011 at 11:52am -0400,
> Moger, Babu <Babu.Moger@netapp.com> wrote:
>
> > All the handlers have implemented the match function(look at patch 1,
> 2, 3).
> > We don't need to use scsi_dev_info any more for matching purposes.
> > Cleaning up the scsi_dh code.
> >
> > FYI..
> > Match function was originally implemented by this
> >
> > http://www.spinics.net/lists/linux-scsi/msg54284.html
> > or
> > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-
> 2.6.git;a=commit;h=6c3633d08acf514e2e89aa95d2346ce 9d64d719a
> >
> > Signed-off-by: Babu Moger <babu.moger@netapp.com>
>
> Looks good, effectively reverts commit 940d7faa481
>
> But SCSI_DEVINFO_DH can be removed too:

Looks good. I missed it. Thanks Mike..I can resend this patch 4/4.


> diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
> index a6ebf4c..1fbf7c7 100644
> --- a/drivers/scsi/scsi_priv.h
> +++ b/drivers/scsi/scsi_priv.h
> @@ -44,7 +44,6 @@ static inline void scsi_log_completion(struct
> scsi_cmnd *cmd, int disposition)
> enum {
> SCSI_DEVINFO_GLOBAL = 0,
> SCSI_DEVINFO_SPI,
> - SCSI_DEVINFO_DH,
> };
>
> extern int scsi_get_device_flags(struct scsi_device *sdev,

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 10:22 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org