CVSROOT: /cvs/dm
Module name: multipath-tools
Branch: RHEL5_FC6
Changes by: bmarzins@sourceware.org 2011-10-24 13:41:32

Modified files:
path_priority/pp_alua: rtpg.c
path_priority/pp_balance_units: pp_balance_units.c

Log message:
Fix for bz #737072. Shorten the timeout for the alua prio callout function
from 5 minutes to 1 minute.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/multipath-tools/path_priority/pp_alua/rtpg.c.diff?cvsroot=dm&only_with_tag=RHEL5_FC6&r1= 1.3.2.5&r2=1.3.2.6
http://sourceware.org/cgi-bin/cvsweb.cgi/multipath-tools/path_priority/pp_balance_units/pp_balance_units.c.diff?cvsroot=dm&only_with_tag=R HEL5_FC6&r1=1.6&r2=1.6.2.1

--- multipath-tools/path_priority/pp_alua/rtpg.c 2009/08/18 21:12:02 1.3.2.5
+++ multipath-tools/path_priority/pp_alua/rtpg.c 2011/10/24 13:41:32 1.3.2.6
@@ -29,7 +29,7 @@
#include "rtpg.h"

#define SENSE_BUFF_LEN 32
-#define DEF_TIMEOUT 300000
+#define DEF_TIMEOUT 60000

/*
* Macro used to print debug messaged.
--- multipath-tools/path_priority/pp_balance_units/pp_balance_units.c 2006/08/02 21:37:24 1.6
+++ multipath-tools/path_priority/pp_balance_units/pp_balance_units.c 2011/10/24 13:41:32 1.6.2.1
@@ -38,7 +38,7 @@
#define INQUIRY_CMDLEN 6
#define INQUIRY_CMD 0x12
#define SENSE_BUFF_LEN 32
-#define DEF_TIMEOUT 300000
+#define DEF_TIMEOUT 60000
#define RECOVERED_ERROR 0x01
#define MX_ALLOC_LEN 255
#define SCSI_CHECK_CONDITION 0x2

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

> --- multipath-tools/path_priority/pp_alua/rtpg.c 2009/08/18 21:12:02 1.3.2.5
> +++ multipath-tools/path_priority/pp_alua/rtpg.c 2011/10/24 13:41:32 1.3.2.6
> @@ -29,7 +29,7 @@
> #include "rtpg.h"
>
> #define SENSE_BUFF_LEN 32
> -#define DEF_TIMEOUT 300000
> +#define DEF_TIMEOUT 60000
>

Do you want that part merged into upstream's alua prioritizer shared
object ?

Regards,
--
Christophe Varoqui
OpenSVC - Tools to scale
http://www.opensvc.com/

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

On Wed, Nov 02, 2011 at 10:51:50PM +0100, Christophe Varoqui wrote:
> > --- multipath-tools/path_priority/pp_alua/rtpg.c 2009/08/18 21:12:02 1.3.2.5
> > +++ multipath-tools/path_priority/pp_alua/rtpg.c 2011/10/24 13:41:32 1.3.2.6
> > @@ -29,7 +29,7 @@
> > #include "rtpg.h"
> >
> > #define SENSE_BUFF_LEN 32
> > -#define DEF_TIMEOUT 300000
> > +#define DEF_TIMEOUT 60000
> >
>
> Do you want that part merged into upstream's alua prioritizer shared
> object ?

In the RHEL5 code, this is a seperate callout program. Upstream it
would be better if we could make this configurable via multipath.conf,
like the checker timeouts.

-Ben

>
> Regards,
> --
> Christophe Varoqui
> OpenSVC - Tools to scale
> http://www.opensvc.com/
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

On jeu., 2011-11-03 at 16:58 -0500, Benjamin Marzinski wrote:
> On Wed, Nov 02, 2011 at 10:51:50PM +0100, Christophe Varoqui wrote:
> > > --- multipath-tools/path_priority/pp_alua/rtpg.c 2009/08/18 21:12:02 1.3.2.5
> > > +++ multipath-tools/path_priority/pp_alua/rtpg.c 2011/10/24 13:41:32 1.3.2.6
> > > @@ -29,7 +29,7 @@
> > > #include "rtpg.h"
> > >
> > > #define SENSE_BUFF_LEN 32
> > > -#define DEF_TIMEOUT 300000
> > > +#define DEF_TIMEOUT 60000
> > >
> >
> > Do you want that part merged into upstream's alua prioritizer shared
> > object ?
>
> In the RHEL5 code, this is a seperate callout program. Upstream it
> would be better if we could make this configurable via multipath.conf,
> like the checker timeouts.
>
Sure, but you did not implement that in the callout either. Is the 60s
timeout value controversial ? Is that change a worthy quick-fix ?

Regards,
--
Christophe Varoqui
OpenSVC - Tools to scale
http://www.opensvc.com/

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

On Thu, Nov 03, 2011 at 11:04:18PM +0100, Christophe Varoqui wrote:
> On jeu., 2011-11-03 at 16:58 -0500, Benjamin Marzinski wrote:
> > On Wed, Nov 02, 2011 at 10:51:50PM +0100, Christophe Varoqui wrote:
> > > > --- multipath-tools/path_priority/pp_alua/rtpg.c 2009/08/18 21:12:02 1.3.2.5
> > > > +++ multipath-tools/path_priority/pp_alua/rtpg.c 2011/10/24 13:41:32 1.3.2.6
> > > > @@ -29,7 +29,7 @@
> > > > #include "rtpg.h"
> > > >
> > > > #define SENSE_BUFF_LEN 32
> > > > -#define DEF_TIMEOUT 300000
> > > > +#define DEF_TIMEOUT 60000
> > > >
> > >
> > > Do you want that part merged into upstream's alua prioritizer shared
> > > object ?
> >
> > In the RHEL5 code, this is a seperate callout program. Upstream it
> > would be better if we could make this configurable via multipath.conf,
> > like the checker timeouts.
> >
> Sure, but you did not implement that in the callout either. Is the 60s
> timeout value controversial ? Is that change a worthy quick-fix ?

Sure. We've had a number of complaints about how long multipath can get
stuck in some corner cases. This was one that caused some problems, so
I'd be happy to see the default changed.

-Ben

>
> Regards,
> --
> Christophe Varoqui
> OpenSVC - Tools to scale
> http://www.opensvc.com/

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel