FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 10-23-2011, 02:30 PM
Michael Leun
 
Default Bisected: Massive memory leak in dm-snapshot in 3.1 development introduced

On Sun, 23 Oct 2011 14:44:49 +0100
Alasdair G Kergon <agk@redhat.com> wrote:

> On Sun, Oct 23, 2011 at 12:52:06PM +0300, Linus Torvalds wrote:
> > Mikulas, Alasdair? I see the mempool_free() for the "master job",
> > what about everything else? Does the dm_kcopyd_prepare_callback()
> > perhaps need to do a
> >
> > job->master_job = job;
> >
> > or similar?
>
> If you look at the other place that performs that mempool_alloc, it's
> indeed present there.
>
> Michael - can you test if this solves the problem?
>
> Alasdair
>
> --- a/drivers/md/dm-kcopyd.c
> +++ b/drivers/md/dm-kcopyd.c
> @@ -628,6 +628,7 @@ void *dm_kcopyd_prepare_callback(struct
> dm_kcopyd_client *kc, job->kc = kc;
> job->fn = fn;
> job->context = context;
> + job->master_job = job;
>
> atomic_inc(&kc->nr_jobs);
>
>

Yup, it indeed does.

--
MfG,

Michael Leun

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 08:37 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org