Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Device-mapper Development (http://www.linux-archive.org/device-mapper-development/)
-   -   DM log userspace: Minor fix-ups (http://www.linux-archive.org/device-mapper-development/587284-dm-log-userspace-minor-fix-ups.html)

Jonathan Brassow 10-13-2011 07:16 PM

DM log userspace: Minor fix-ups
 
dm-log-userspace: use kzalloc instead of kmalloc (plus some comment fixes)

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>

Index: linux-upstream/drivers/md/dm-log-userspace-base.c
================================================== =================
--- linux-upstream.orig/drivers/md/dm-log-userspace-base.c
+++ linux-upstream/drivers/md/dm-log-userspace-base.c
@@ -146,7 +146,7 @@ static int build_constructor_string(stru
* <UUID> <other args>
* Where 'other args' is the userspace implementation specific log
* arguments. An example might be:
- * <UUID> clustered_disk <arg count> <log dev> <region_size> [[no]sync]
+ * <UUID> clustered-disk <arg count> <log dev> <region_size> [[no]sync]
*
* So, this module will strip off the <UUID> for identification purposes
* when communicating with userspace about a log; but will pass on everything
@@ -167,7 +167,7 @@ static int userspace_ctr(struct dm_dirty
return -EINVAL;
}

- lc = kmalloc(sizeof(*lc), GFP_KERNEL);
+ lc = kzalloc(sizeof(*lc), GFP_KERNEL);
if (!lc) {
DMWARN("Unable to allocate userspace log context.");
return -ENOMEM;
Index: linux-upstream/Documentation/device-mapper/dm-log.txt
================================================== =================
--- linux-upstream.orig/Documentation/device-mapper/dm-log.txt
+++ linux-upstream/Documentation/device-mapper/dm-log.txt
@@ -48,7 +48,7 @@ kernel and userspace, 'connector' is use
communication.

There are currently two userspace log implementations that leverage this
-framework - "clustered_disk" and "clustered_core". These implementations
+framework - "clustered-disk" and "clustered-core". These implementations
provide a cluster-coherent log for shared-storage. Device-mapper mirroring
can be used in a shared-storage environment when the cluster log implementations
are employed.


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Alasdair G Kergon 10-19-2011 12:13 AM

DM log userspace: Minor fix-ups
 
On Thu, Oct 13, 2011 at 02:16:34PM -0500, Jon Brassow wrote:
> dm-log-userspace: use kzalloc instead of kmalloc

But what's the reason?

Is this fixing a bug or not?

The patch header needs to tell us so we know whether this should be
backported to stable or not, for example.

Alasdair

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Jonathan Brassow 10-19-2011 09:02 PM

DM log userspace: Minor fix-ups
 
dm-log-userspace: comment fixes

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>

Index: linux-upstream/drivers/md/dm-log-userspace-base.c
================================================== =================
--- linux-upstream.orig/drivers/md/dm-log-userspace-base.c
+++ linux-upstream/drivers/md/dm-log-userspace-base.c
@@ -146,7 +146,7 @@ static int build_constructor_string(stru
* <UUID> <other args>
* Where 'other args' is the userspace implementation specific log
* arguments. An example might be:
- * <UUID> clustered_disk <arg count> <log dev> <region_size> [[no]sync]
+ * <UUID> clustered-disk <arg count> <log dev> <region_size> [[no]sync]
*
* So, this module will strip off the <UUID> for identification purposes
* when communicating with userspace about a log; but will pass on everything
Index: linux-upstream/Documentation/device-mapper/dm-log.txt
================================================== =================
--- linux-upstream.orig/Documentation/device-mapper/dm-log.txt
+++ linux-upstream/Documentation/device-mapper/dm-log.txt
@@ -48,7 +48,7 @@ kernel and userspace, 'connector' is use
communication.

There are currently two userspace log implementations that leverage this
-framework - "clustered_disk" and "clustered_core". These implementations
+framework - "clustered-disk" and "clustered-core". These implementations
provide a cluster-coherent log for shared-storage. Device-mapper mirroring
can be used in a shared-storage environment when the cluster log implementations
are employed.


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


All times are GMT. The time now is 12:23 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.