Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Device-mapper Development (http://www.linux-archive.org/device-mapper-development/)
-   -   multipath: get right sysfs value for checker_timeout (http://www.linux-archive.org/device-mapper-development/583705-multipath-get-right-sysfs-value-checker_timeout.html)

Benjamin Marzinski 10-05-2011 04:15 AM

multipath: get right sysfs value for checker_timeout
 
sysfs_get_timeout() wasn't looking in the correct directory for the
checker timeout value. It was looking at .../block/<devname>/timeout,
instead of .../block/<devname>/device/timeout

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/discovery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: multipath-tools-110916/libmultipath/discovery.c
================================================== =================
--- multipath-tools-110916.orig/libmultipath/discovery.c
+++ multipath-tools-110916/libmultipath/discovery.c
@@ -166,7 +166,7 @@ sysfs_get_timeout(struct sysfs_device *d
if (safe_sprintf(attr_path, "%s/device", dev->devpath))
return 1;

- len = sysfs_attr_get_value(dev->devpath, "timeout", attr, NAME_SIZE);
+ len = sysfs_attr_get_value(attr_path, "timeout", attr, NAME_SIZE);
if (!len) {
condlog(3, "%s: No timeout value in sysfs", dev->devpath);
return 1;

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Christophe Varoqui 10-05-2011 08:45 PM

multipath: get right sysfs value for checker_timeout
 
On mar., 2011-10-04 at 23:15 -0500, Benjamin Marzinski wrote:
> sysfs_get_timeout() wasn't looking in the correct directory for the
> checker timeout value. It was looking at .../block/<devname>/timeout,
> instead of .../block/<devname>/device/timeout
>
Merged.

> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> libmultipath/discovery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: multipath-tools-110916/libmultipath/discovery.c
> ================================================== =================
> --- multipath-tools-110916.orig/libmultipath/discovery.c
> +++ multipath-tools-110916/libmultipath/discovery.c
> @@ -166,7 +166,7 @@ sysfs_get_timeout(struct sysfs_device *d
> if (safe_sprintf(attr_path, "%s/device", dev->devpath))
> return 1;
>
> - len = sysfs_attr_get_value(dev->devpath, "timeout", attr, NAME_SIZE);
> + len = sysfs_attr_get_value(attr_path, "timeout", attr, NAME_SIZE);
> if (!len) {
> condlog(3, "%s: No timeout value in sysfs", dev->devpath);
> return 1;


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


All times are GMT. The time now is 09:10 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.