FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 09-01-2011, 06:30 PM
Benjamin Marzinski
 
Default multipath: strdup multipath alias, so that it isn't deleted.

On Thu, Sep 01, 2011 at 08:55:18AM +0200, Christophe Varoqui wrote:
> On mer., 2011-08-31 at 21:45 -0500, Benjamin Marzinski wrote:
> > When a multipath device is added to multipathd with ev_add_map(),
> > > the alias is not duplicated, and is freed immediately after
> > ev_add_map()
> > > returns, causing a memory error. This patch corrects that.
> > >
> Merged.
>
> Do you think the "mpp->alias = NULL" is still necessary in the following
> setup_multipath() error code path ? alias is set to NULL by
> free_multipath() these days ...
>

Yeah, that looks like it can safely go.

-Ben

> > if (setup_multipath(vecs, mpp)) {
> > mpp->alias = NULL; <========

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 09:33 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org