FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 07-21-2011, 09:56 PM
Randy Dunlap
 
Default linux-next: Tree for July 21 (drivers/md/dm-raid)

On Thu, 21 Jul 2011 16:55:42 +1000 Stephen Rothwell wrote:

> Hi all,

When CONFIG_DM_RAID=m and CONFIG_MD_RAID1 is not enabled:

ERROR: "md_raid1_congested" [drivers/md/dm-raid.ko] undefined!

due to:

if (rs->raid_type->level == 1)
return md_raid1_congested(&rs->md, bits);

Should that just be surrounded with this?

#if defined(CONFIG_MD_RAID1) || defined(CONFIG_MD_RAID1_MODULE)
...
#endif

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 07-21-2011, 10:10 PM
NeilBrown
 
Default linux-next: Tree for July 21 (drivers/md/dm-raid)

On Thu, 21 Jul 2011 14:56:48 -0700 Randy Dunlap <rdunlap@xenotime.net> wrote:

> On Thu, 21 Jul 2011 16:55:42 +1000 Stephen Rothwell wrote:
>
> > Hi all,
>
> When CONFIG_DM_RAID=m and CONFIG_MD_RAID1 is not enabled:
>
> ERROR: "md_raid1_congested" [drivers/md/dm-raid.ko] undefined!
>
> due to:
>
> if (rs->raid_type->level == 1)
> return md_raid1_congested(&rs->md, bits);
>
> Should that just be surrounded with this?
>
> #if defined(CONFIG_MD_RAID1) || defined(CONFIG_MD_RAID1_MODULE)
> ...
> #endif
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***


I suspect the right thing to do is add
select MD_RAID1
to the
config DM_RAID

stanza. What do you think Jon?

NeilBrown

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 07-22-2011, 01:14 AM
Alasdair G Kergon
 
Default linux-next: Tree for July 21 (drivers/md/dm-raid)

On Fri, Jul 22, 2011 at 08:10:40AM +1000, Neil Brown wrote:
> I suspect the right thing to do is add
> select MD_RAID1
> to the
> config DM_RAID

Indeed - done.

Alasdair

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 05:33 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org