FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 07-28-2010, 10:59 PM
"Moger, Babu"
 
Default scsi_dh : release the refcounts in scsi_dh_alua handler when activate is complete

This patch releases the refcounts when activate is complete in alua handler.

Signed-off-by: Babu Moger <babu.moger@lsi.com>
---
--- linux-2.6.35-rc5/drivers/scsi/device_handler/scsi_dh_alua.c.orig 2010-07-23 05:58:39.000000000 -0500
+++ linux-2.6.35-rc5/drivers/scsi/device_handler/scsi_dh_alua.c 2010-07-23 06:00:54.000000000 -0500
@@ -287,6 +287,8 @@ done:
h->callback_fn(h->callback_data, err);
h->callback_fn = h->callback_data = NULL;
}
+ kref_put(&h->sdev->scsi_dh_data->kref, scsi_dh_handler_cleanup);
+ put_device(&h->sdev->sdev_gendev);
return;
}

@@ -684,6 +686,8 @@ static int alua_activate(struct scsi_dev
out:
if (fn)
fn(data, err);
+ kref_put(&sdev->scsi_dh_data->kref, scsi_dh_handler_cleanup);
+ put_device(&sdev->sdev_gendev);
return 0;
}




--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 07-30-2010, 12:12 AM
James Bottomley
 
Default scsi_dh : release the refcounts in scsi_dh_alua handler when activate is complete

On Wed, 2010-07-28 at 16:59 -0600, Moger, Babu wrote:
> This patch releases the refcounts when activate is complete in alua handler.
>
> Signed-off-by: Babu Moger <babu.moger@lsi.com>
> ---
> --- linux-2.6.35-rc5/drivers/scsi/device_handler/scsi_dh_alua.c.orig 2010-07-23 05:58:39.000000000 -0500
> +++ linux-2.6.35-rc5/drivers/scsi/device_handler/scsi_dh_alua.c 2010-07-23 06:00:54.000000000 -0500
> @@ -287,6 +287,8 @@ done:
> h->callback_fn(h->callback_data, err);
> h->callback_fn = h->callback_data = NULL;
> }
> + kref_put(&h->sdev->scsi_dh_data->kref, scsi_dh_handler_cleanup);
> + put_device(&h->sdev->sdev_gendev);
> return;
> }
>
> @@ -684,6 +686,8 @@ static int alua_activate(struct scsi_dev
> out:
> if (fn)
> fn(data, err);
> + kref_put(&sdev->scsi_dh_data->kref, scsi_dh_handler_cleanup);
> + put_device(&sdev->sdev_gendev);

This sequence is asking for trouble: having to remember to release two
separate references at once.

Logically what should happen is that the reference seems to be on
scsi_dh_data->sdev, so it should be taken when that's initialised and
put in scsi_dh_handler_cleanup ... so no-one has to worry about
forgetting it.

James


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 06:48 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org