FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.

» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

LinkBack Thread Tools
Old 07-28-2010, 12:46 AM
Malahal Naineni
Default dm-multipath: typo, strncat instead of strncpy

strncat here doesn't seem right, strncpy should be correct!

Signed-off-by: Malahal Naineni (malahal@us.ibm.com)

PS: But why bother correcting an entry that is going to be deleted
anyway? IMO, just deleting the strncat/strncpy line should be fine too.
Any comments???

diff -r 62c20b65bffe -r 07a9bab4a67f libmultipath/configure.c
--- a/libmultipath/configure.c Tue Jul 20 17:08:44 2010 -0700
+++ b/libmultipath/configure.c Tue Jul 27 17:45:48 2010 -0700
@@ -170,7 +170,7 @@ select_action (struct multipath * mpp, v
if (!find_mp_by_wwid(curmp, mpp->wwid)) {
condlog(2, "%s: remove (wwid changed)", cmpp->alias);
- strncat(cmpp->wwid, mpp->wwid, WWID_SIZE);
+ strncpy(cmpp->wwid, mpp->wwid, WWID_SIZE);
drop_multipath(curmp, cmpp->wwid, KEEP_PATHS);
mpp->action = ACT_CREATE;
condlog(3, "%s: set ACT_CREATE (map wwid change)",

dm-devel mailing list

Thread Tools

All times are GMT. The time now is 05:27 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org