rq-based mpath failed path on SCSI target failure (malformed discard)
On Mon, Jul 26 2010 at 12:23pm -0400,
Mike Christie <firstname.lastname@example.org> wrote:
> On 07/26/2010 10:00 AM, Mike Snitzer wrote:
> >diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> >index ec2b43e..125c80f 100644
> >--- a/drivers/md/dm-mpath.c
> >+++ b/drivers/md/dm-mpath.c
> >@@ -1272,6 +1272,9 @@ static int do_end_io(struct multipath *m, struct request *clone,
> > if (error == -EOPNOTSUPP)
> > return error;
> >+ if (clone->cmd_flags& REQ_DISCARD)
> >+ return error; /* pass all discard request failures up */
> If a discard where failed due to a transport problem then you are
> going to fail the IO instead of just retrying on another path.
> You need something like Hannes's work to pass up the sense, or
> something like generic block error codes like I started to work on,
> so you know why the IO failed.
Thanks for reminding me about previous work done in the area of error
Yes, we certainly need a more intelligent check but since neither of the
solutions you referenced are available yet we're better off failing the
discard in the near-term. Clearly not ideal but failing a path when an
optional discard IO failure occurs isn't going to fly either.
I'll slap a FIXME on this interim "fix".
In parallel I'll see if I can track down Hannes' and/or your work,
rebase it as needed, etc. If you have updated patches please let me
dm-devel mailing list