FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.

» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

LinkBack Thread Tools
Old 05-04-2010, 03:36 AM
Mike Anderson
Default blk: scsi: blk abort queue updates

This patch series has three sections explained below. The patches are
presented as a series as they hit some common functions and may need to
be applied in order to avoid conflicts.

1.) Avoid possibly waking up the error handler on a queue that it stopped.
blk: Do not abort requests if queue is stopped

2.) It is possible to have a request on the elevator that is already
prepped. The prepped resources should be released also. This was seen under
heavy IO load while a lot of requeue activity as going occurring.

blk: In elv_abort_queue skip requests with REQ_DONTPREP set
blk: Add a unprep_rq_fn
blk: Call unprep_fn from elv_abort_queue is available
scsi: Add a scsi_unprep_fn

3.) These four patches add a flag to a request indicating that a block
abort has been called on the request. It also adds a common
scsi_requeue_request so that the flag can be checked in only one location
on a attempt to requeue.

Currently we may abort a request and post error recovery the request can
be requeued. We may also try to abort a request that is in the process of
completing that we would like to prevent a requeue on.

The abort flag is different than a fast fail flag in that it is provides a
hint that the request should be returned as soon as possible (i.e. do not
requeue even if disposition indicates that it would be allowed).

The change allowed failovers that where exceeding (SD_MAX_RETRIES * IO
TIMEOUT) to be able to failover in less than a single timeout (the less
than case depended on the type of event that triggered the path failure).

blk: Add request atomic flag for abort
blk: Mark requests aborted
scsi: Add scsi_requeue_request function
scsi: Add blk_request_aborted check

I tested the patches on a IBM,2105800 connected through a zfcp adapter,
a IBM,1815 through a qlogic adapter, and scsi_debug.

block/blk-settings.c | 17 +++++++++++
block/blk-timeout.c | 19 +++++++++++-
block/blk.h | 14 +++++++++
block/elevator.c | 25 ++++++++++++++--
drivers/scsi/scsi_lib.c | 73 +++++++++++++++++++++++++++++++---------------
include/linux/blkdev.h | 4 ++
6 files changed, 123 insertions(+), 29 deletions(-)

dm-devel mailing list

Thread Tools

All times are GMT. The time now is 02:05 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org