dm_ioctl: use nonseekable_open
From: Arnd Bergmann <arnd@relay.de.ibm.com>
The dm control device does not implement read/write, so it has no use for seeking. Using no_llseek prevents falling back to default_llseek, which requires the BKL. [fweisbec@gmail.com: drop useless llseek = no_llseek] Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Alasdair G Kergon <agk@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- drivers/md/dm-ioctl.c | 1 + 1 file changed, 1 insertion(+) diff -puN drivers/md/dm-ioctl.c~dm_ioctl-use-nonseekable_open drivers/md/dm-ioctl.c --- a/drivers/md/dm-ioctl.c~dm_ioctl-use-nonseekable_open +++ a/drivers/md/dm-ioctl.c @@ -1593,6 +1593,7 @@ static long dm_compat_ctl_ioctl(struct f #endif static const struct file_operations _ctl_fops = { + .open = nonseekable_open, .unlocked_ioctl = dm_ctl_ioctl, .compat_ioctl = dm_compat_ctl_ioctl, .owner = THIS_MODULE, _ -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel |
| All times are GMT. The time now is 11:45 AM. |
VBulletin, Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.