FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 04-20-2010, 07:15 AM
Mikulas Patocka
 
Default Current shared snapshots

Hi

I uploaded current shared snapshots at
http://people.redhat.com/mpatocka/patches/kernel/new-snapshots/r19/

Changes: cache shrinking over time, removed unused code, documentation
changes from you.

It doesn't contain variable renaming patches that you sent me, I think
it's not needed and also --- renaming variables with regular expressions
is dangerous. It may patch something that wasn't intended to be patched.

Mikulas

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 04-20-2010, 03:03 PM
Mike Snitzer
 
Default Current shared snapshots

On Tue, Apr 20 2010 at 3:15am -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:

> Hi
>
> I uploaded current shared snapshots at
> http://people.redhat.com/mpatocka/patches/kernel/new-snapshots/r19/
>
> Changes: cache shrinking over time, removed unused code, documentation
> changes from you.
>
> It doesn't contain variable renaming patches that you sent me, I think
> it's not needed and also --- renaming variables with regular expressions
> is dangerous. It may patch something that wasn't intended to be patched.

That is unfortunate. I guess I won't waste my time on such cleanups in
the future. Seriously, dismissing those changes as "not needed" is
frustrating. Those changes really do serve to add consistency.

Your concern about using regex to do renames is valid but hardly reason
to dismiss changes. Any unwanted change is easily caught by compiling
the result.

I really do hope you'll reconsider taking those rename changes. I'll
refresh and re-review the changes against r19 if you're willing to
reconsider.

Mike

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 04-22-2010, 09:01 PM
Mike Snitzer
 
Default Current shared snapshots

On Tue, Apr 20 2010 at 3:15am -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:

> Hi
>
> I uploaded current shared snapshots at
> http://people.redhat.com/mpatocka/patches/kernel/new-snapshots/r19/
>
> Changes: cache shrinking over time, removed unused code, documentation
> changes from you.

When you included my dm-multisnapshot.txt changes my email's header
snuck in, this patch cleans that up:

diff --git a/Documentation/device-mapper/dm-multisnapshot.txt b/Documentation/device-mapper/dm-multisnapshot.txt
index cd0ff83..4ffa916 100644
--- a/Documentation/device-mapper/dm-multisnapshot.txt
+++ b/Documentation/device-mapper/dm-multisnapshot.txt
@@ -1,19 +1,3 @@
-From snitzer@redhat.com Tue Mar 30 12:27:02 2010
-Date: Tue, 30 Mar 2010 12:26:21 -0400
-From: Mike Snitzer <snitzer@redhat.com>
-To: Mikulas Patocka <mpatocka@redhat.com>
-Cc: device-mapper development <dm-devel@redhat.com>, Alasdair G Kergon <agk@redhat.com>
-Subject: Re: Shared snapshots
-
-On Wed, Dec 16 2009 at 3:39pm -0500,
-Mike Snitzer <snitzer@redhat.com> wrote:
-
-> As an aside, I have some ideas for improving
-> Documentation/device-mapper/dm-multisnapshot.txt
-> I'll just send a patch and we can go from there.
-
-OK, here is the updated dm-multisnapshot.txt (finally):
-
Device-mapper multiple snapshot support
=======================================


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 12:47 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org