FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 02-01-2010, 02:39 PM
Milan Broz
 
Default dm_crypt: Issue all previous bios before remapping barrier bio

On 02/01/2010 04:19 PM, Nikanth Karthikesan wrote:
> Before remapping a barrier bio, make sure that there are no un-issued
> pending I/O in the workqueue. Otherwise a dm_flush would simply add
> a barrier request to the underlying device, without issuing the bio's
> queued in the dm_crypt device.

This should not be needed. Core dm code waits for all bios submitted before
barrier requests.

Mikulas, could you verify it?

Milan

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 02-02-2010, 11:47 AM
Mikulas Patocka
 
Default dm_crypt: Issue all previous bios before remapping barrier bio

On Mon, 1 Feb 2010, Milan Broz wrote:

> On 02/01/2010 04:19 PM, Nikanth Karthikesan wrote:
> > Before remapping a barrier bio, make sure that there are no un-issued
> > pending I/O in the workqueue. Otherwise a dm_flush would simply add
> > a barrier request to the underlying device, without issuing the bio's
> > queued in the dm_crypt device.
>
> This should not be needed. Core dm code waits for all bios submitted before
> barrier requests.
>
> Mikulas, could you verify it?
>
> Milan

Yes, you are right, the patch is not needed.

When the target receives an empty barrier request, there are no other data
requests in flight.

BTW. The target may receive more empty barrier requests simultaneously, if
it asked for it by setting ti->num_flush_requests to more than one. But
barrier and non-barrier requests are never mixed.

Mikulas

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 09:57 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org