Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Device-mapper Development (http://www.linux-archive.org/device-mapper-development/)
-   -   DM Snapshot: get rid of __free_exceptions fn (http://www.linux-archive.org/device-mapper-development/266476-dm-snapshot-get-rid-__free_exceptions-fn.html)

Jonathan Brassow 03-19-2009 08:36 PM

DM Snapshot: get rid of __free_exceptions fn
 
Patch name: dm-snap-get-rid-of-__free_exceptions-fn.patch

The __free_exceptions function is only three lines long and
used in only one place. We'll need to break-up and re-order those
lines in later patches, so we get rid of the function entirely.

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>

Index: linux-2.6/drivers/md/dm-snap.c
================================================== =================
--- linux-2.6.orig/drivers/md/dm-snap.c
+++ linux-2.6/drivers/md/dm-snap.c
@@ -578,14 +578,6 @@ bad_snap:
return r;
}

-static void __free_exceptions(struct dm_snapshot *s)
-{
- dm_kcopyd_client_destroy(s->kcopyd_client);
- s->kcopyd_client = NULL;
-
- dm_exception_table_destroy(s->pending);
-}
-
static void snapshot_dtr(struct dm_target *ti)
{
#ifdef CONFIG_DM_DEBUG
@@ -614,7 +606,10 @@ static void snapshot_dtr(struct dm_targe

mempool_destroy(s->tracked_chunk_pool);

- __free_exceptions(s);
+ dm_kcopyd_client_destroy(s->kcopyd_client);
+ s->kcopyd_client = NULL;
+
+ dm_exception_table_destroy(s->pending);

mempool_destroy(s->pending_pool);


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Jonathan Brassow 03-25-2009 08:38 PM

DM Snapshot: get rid of __free_exceptions fn
 
Patch name: dm-snap-get-rid-of-__free_exceptions-fn.patch

The __free_exceptions function is only three lines long and
used in only one place. We'll need to break-up and re-order those
lines in later patches, so we get rid of the function entirely.

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>

Index: linux-2.6/drivers/md/dm-snap.c
================================================== =================
--- linux-2.6.orig/drivers/md/dm-snap.c
+++ linux-2.6/drivers/md/dm-snap.c
@@ -578,14 +578,6 @@ bad_snap:
return r;
}

-static void __free_exceptions(struct dm_snapshot *s)
-{
- dm_kcopyd_client_destroy(s->kcopyd_client);
- s->kcopyd_client = NULL;
-
- dm_exception_table_destroy(s->pending);
-}
-
static void snapshot_dtr(struct dm_target *ti)
{
#ifdef CONFIG_DM_DEBUG
@@ -614,7 +606,10 @@ static void snapshot_dtr(struct dm_targe

mempool_destroy(s->tracked_chunk_pool);

- __free_exceptions(s);
+ dm_kcopyd_client_destroy(s->kcopyd_client);
+ s->kcopyd_client = NULL;
+
+ dm_exception_table_destroy(s->pending);

mempool_destroy(s->pending_pool);


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


All times are GMT. The time now is 01:40 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.