FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 03-10-2009, 02:46 PM
James Bottomley
 
Default scsi_dh_rdac: Retry for NOT_READY check condition (0x02A102, 0x020401, 0x020404 and 0x020407) in rdac_check_sense

On Tue, 2009-03-10 at 18:30 +0530, Chauhan, Vijay wrote:
> This patch adds retry for NOT_READY check conditions(02/A1/02, 02/04/01, 02/04/04,
> 02/04/07) in rdac_check_sense.
>
> Signed-off-by: Vijay Chauhan<vijay.chauhan@lsi.com>
>
> ---
> --- linux-2.6.29-rc7/drivers/scsi/device_handler/scsi_dh_rdac.c.orig 2009-03-10 17:42:27.000000000 +0530
> +++ linux-2.6.29-rc7/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-03-10 18:05:35.000000000 +0530
> @@ -562,6 +562,30 @@ static int rdac_check_sense(struct scsi_
> * Just retry and wait.
> */
> return ADD_TO_MLQUEUE;
> + if (sense_hdr->asc == 0xA1 && sense_hdr->ascq == 0x02)
> + /* LUN Not Ready - Quiescense in progress
> + * or has been achieved
> + * Just retry.
> + */
> + return ADD_TO_MLQUEUE;

This is fine, being vendor specific, we don't handle it at the mid-layer

> + if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x01)
> + /* LUN Not Ready - Logical Unit Not Ready and is in
> + * the process of becoming ready
> + * Just retry.
> + */
> + return ADD_TO_MLQUEUE;
> + if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x04)
> + /* LUN Not Ready - Format In Progress
> + *
> + * Just retry.
> + */
> + return ADD_TO_MLQUEUE;
> + if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x07)
> + /* LUN Not Ready - Storage controller cannot respond
> + * immediately to a PRIN or PROUT command.
> + * Just retry.
> + */
> + return ADD_TO_MLQUEUE;

For all of these ... along with a few other not ready types, we already
do a delayed retry at the mid-layer (in scsi_io_completion). Is there
some problem that causes this to need to be handled here as well?

James


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 03-17-2009, 12:21 PM
"Chauhan, Vijay"
 
Default scsi_dh_rdac: Retry for NOT_READY check condition (0x02A102, 0x020401, 0x020404 and 0x020407) in rdac_check_sense

Hi James,

Thanks for your comment. I have updated the patch with your comments.

On Tues, 2009-03-10 21:17 +0530, James Bottomley wrote:
> > + if (sense_hdr->asc == 0xA1 && sense_hdr->ascq == 0x02)
> > + /* LUN Not Ready - Quiescense in progress
> > + * or has been achieved
> > + * Just retry.
> > + */
> > + return ADD_TO_MLQUEUE;
>
> This is fine, being vendor specific, we don't handle it at
> the mid-layer

> > + if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x07)
> > + /* LUN Not Ready - Storage controller
> cannot respond
> > + * immediately to a PRIN or PROUT command.
> > + * Just retry.
> > + */
> > + return ADD_TO_MLQUEUE;
>
> For all of these ... along with a few other not ready types,
> we already
> do a delayed retry at the mid-layer (in scsi_io_completion). Is there
> some problem that causes this to need to be handled here as well?
>
Yes, I do agree. Submitting patch for 0x02A102 only.

Thanks,
Vijay

---
This patch adds retry for NOT_READY check condition - Quiescense in progress (02/A1/02)

Signed-off-by: Vijay Chauhan<vijay.chauhan@lsi.com>

---
--- linux-2.6.29-rc7/drivers/scsi/device_handler/scsi_dh_rdac.c.orig 2009-03-10 17:42:27.000000000 +0530
+++ linux-2.6.29-rc7/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-03-17 18:18:07.000000000 +0530
@@ -562,6 +562,12 @@ static int rdac_check_sense(struct scsi_
* Just retry and wait.
*/
return ADD_TO_MLQUEUE;
+ if (sense_hdr->asc == 0xA1 && sense_hdr->ascq == 0x02)
+ /* LUN Not Ready - Quiescense in progress
+ * or has been achieved
+ * Just retry.
+ */
+ return ADD_TO_MLQUEUE;
break;
case ILLEGAL_REQUEST:
if (sense_hdr->asc == 0x94 && sense_hdr->ascq == 0x01) {
--

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 03-24-2009, 06:38 PM
Chandra Seetharaman
 
Default scsi_dh_rdac: Retry for NOT_READY check condition (0x02A102, 0x020401, 0x020404 and 0x020407) in rdac_check_sense

On Tue, 2009-03-17 at 18:51 +0530, Chauhan, Vijay wrote:
> Hi James,
>
> Thanks for your comment. I have updated the patch with your comments.
>
> On Tues, 2009-03-10 21:17 +0530, James Bottomley wrote:
> > > + if (sense_hdr->asc == 0xA1 && sense_hdr->ascq == 0x02)
> > > + /* LUN Not Ready - Quiescense in progress
> > > + * or has been achieved
> > > + * Just retry.
> > > + */
> > > + return ADD_TO_MLQUEUE;
> >
> > This is fine, being vendor specific, we don't handle it at
> > the mid-layer
>
> > > + if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x07)
> > > + /* LUN Not Ready - Storage controller
> > cannot respond
> > > + * immediately to a PRIN or PROUT command.
> > > + * Just retry.
> > > + */
> > > + return ADD_TO_MLQUEUE;
> >
> > For all of these ... along with a few other not ready types,
> > we already
> > do a delayed retry at the mid-layer (in scsi_io_completion). Is there
> > some problem that causes this to need to be handled here as well?
> >
> Yes, I do agree. Submitting patch for 0x02A102 only.
>
> Thanks,
> Vijay
>
> ---
> This patch adds retry for NOT_READY check condition - Quiescense in progress (02/A1/02)
>
> Signed-off-by: Vijay Chauhan<vijay.chauhan@lsi.com>

Acked-by: Chandra Seetharaman <sekharan@us.ibm.com>

>
> ---
> --- linux-2.6.29-rc7/drivers/scsi/device_handler/scsi_dh_rdac.c.orig 2009-03-10 17:42:27.000000000 +0530
> +++ linux-2.6.29-rc7/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-03-17 18:18:07.000000000 +0530
> @@ -562,6 +562,12 @@ static int rdac_check_sense(struct scsi_
> * Just retry and wait.
> */
> return ADD_TO_MLQUEUE;
> + if (sense_hdr->asc == 0xA1 && sense_hdr->ascq == 0x02)
> + /* LUN Not Ready - Quiescense in progress
> + * or has been achieved
> + * Just retry.
> + */
> + return ADD_TO_MLQUEUE;
> break;
> case ILLEGAL_REQUEST:
> if (sense_hdr->asc == 0x94 && sense_hdr->ascq == 0x01) {
> ----
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 11:24 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org