FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 01-07-2009, 01:59 AM
Alasdair G Kergon
 
Default Patchwork and patch flow

Patchwork was recently installed on kernel.org and dm-devel has been
added as I'd like to try it out as a way of keeping track of
patches posted to this list.

http://patchwork.kernel.org/project/dm-devel/list/

I'd also like to see more people visibly reviewing and testing patches.
Please respond in the mailing list threads with comments and Reviewed-by: or
Tested-by: lines as appropriate. If you've only reviewed part of the patch
or only tested a subset of the cases you think need testing, explain in the
thread but don't add those lines. Only offer a Reviewed-by line if you have
performed a complete line-by-line review of the patch and patch header and
you support its inclusion in the tree.

Also, if you post a patch, try to find suitable people to review and test it
for you and ask them to respond as above in the thread.

If you can't find people to do that, consider whether you ought to change
the patches in some way (usually breaking them into smaller compilable parts)
to make them easier to test and review.

I would like us to work towards a situation where each patch gets documented
as having been reviewed and tested before it hits its respective tree (the
linux-next tree in the case of kernel patches).

The current flow of kernel patches is:
dm-devel list
-> dm quilt tree
- http://www.kernel.org/pub/linux/kernel/people/agk/patches/2.6/editing/
- typically edit the series file to place the new patches you want to test
immediately below the 'mm' patch.
-> -mm
-> linux-next
- patches should have Reviewed-by and Tested-by lines before this stage
-> linux-dm git (rebased for every set of patches)
- http://git.kernel.org/?p=linux/kernel/git/agk/linux-2.6-dm.git
-> linux-2.6

Userspace multipath-tools patches go:
dm-devel list -> Christoph Varoqui who checks them in.

Userspace dmsetup and libdevmapper patches go:
Either lvm-devel or dm-devel list -> CVS
(Some simple patches may be reviewed on lvm-devel after they are committed
rather than before.)

Alasdair
--
agk@redhat.com

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 01-09-2009, 12:00 AM
Alasdair G Kergon
 
Default Patchwork and patch flow

Patchwork states for kernel patches.

Awaiting Upstream
- Will go upstream at the next opportunity, which normally means it is included
in the linux-next tree.

Under Review
- The patch is included in my 'editing' tree at:
http://www.kernel.org/pub/linux/kernel/people/agk/patches/2.6/editing/
and is awaiting Reviewed-by and Tested-by signoffs.
It may or may not also be in -mm.

A Delegate assigned - this person is performing (or co-ordinating) the main
review of the patch.

Accepted
- It's not clear how best to use this state. To start with, we'll try using
it as the final state when a patch arrives in Linus's git.

So New->Under Review->Awaiting Upstream->Accepted. Then it will get 'archived'.

Alasdair
--
agk@redhat.com

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 02-05-2009, 10:45 AM
Ryo Tsuruta
 
Default Patchwork and patch flow

Hi Alasdair,

> I'd also like to see more people visibly reviewing and testing patches.
> Please respond in the mailing list threads with comments and Reviewed-by: or
> Tested-by: lines as appropriate. If you've only reviewed part of the patch
> or only tested a subset of the cases you think need testing, explain in the
> thread but don't add those lines. Only offer a Reviewed-by line if you have
> performed a complete line-by-line review of the patch and patch header and
> you support its inclusion in the tree.

To add a Tested-by tag, how much test do we actually need?
We've already done several tests of dm-ioband:
Proportional I/O bandwidth controlling
Loading/unloading driver and changing settings while under I/O load
Bounds checking of setting parameters
Benchmarks
Do you think these are enough for adding the tag?
It's very difficult for me to determine whether it's qualified or not.
It would be helpful if you could give me some advice.

Thanks,
Ryo Tsuruta

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 02-05-2009, 09:12 PM
Jonathan Brassow
 
Default Patchwork and patch flow

On Feb 5, 2009, at 5:45 AM, Ryo Tsuruta wrote:


Hi Alasdair,

I'd also like to see more people visibly reviewing and testing
patches.
Please respond in the mailing list threads with comments and
Reviewed-by: or
Tested-by: lines as appropriate. If you've only reviewed part of
the patch
or only tested a subset of the cases you think need testing,
explain in the
thread but don't add those lines. Only offer a Reviewed-by line if
you have
performed a complete line-by-line review of the patch and patch
header and

you support its inclusion in the tree.


To add a Tested-by tag, how much test do we actually need?
We've already done several tests of dm-ioband:
Proportional I/O bandwidth controlling
Loading/unloading driver and changing settings while under I/O load
Bounds checking of setting parameters
Benchmarks
Do you think these are enough for adding the tag?
It's very difficult for me to determine whether it's qualified or not.
It would be helpful if you could give me some advice.


Interesting question... If it was me, I'd like to see exactly what
you wrote above. State that you tested it and how you tested it. If
there are a number of people who test it and the things they describe
offer a broad spectrum of tests, I think that's helpful. Also, if
extra testing is wanted, it can be suggested based on what tests have
been performed.


brassow

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 02-05-2009, 09:48 PM
Alasdair G Kergon
 
Default Patchwork and patch flow

The key thing I'm looking for in Tested-By is independence from
the original developers.

Alasdair
--
agk@redhat.com

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 02-06-2009, 05:42 AM
Ryo Tsuruta
 
Default Patchwork and patch flow

Hi Jonathan and Alasdair,

Thanks for your advices.

> > To add a Tested-by tag, how much test do we actually need?
> > We've already done several tests of dm-ioband:
> > Proportional I/O bandwidth controlling
> > Loading/unloading driver and changing settings while under I/O load
> > Bounds checking of setting parameters
> > Benchmarks
> > Do you think these are enough for adding the tag?
> > It's very difficult for me to determine whether it's qualified or not.
> > It would be helpful if you could give me some advice.
>
> Interesting question... If it was me, I'd like to see exactly what
> you wrote above. State that you tested it and how you tested it. If
> there are a number of people who test it and the things they
> describe offer a broad spectrum of tests, I think that's helpful.
> Also, if extra testing is wanted, it can be suggested based on what
> tests have been performed.

O.K. I will post my test items and results on my website sometime
soon.

> The key thing I'm looking for in Tested-By is independence from
> the original developers.

I think so. I hope someone will do the test by posting my test items.

Thanks,
Ryo Tsuruta

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 02-13-2009, 08:25 AM
Ryo Tsuruta
 
Default Patchwork and patch flow

Hi Jonathan, Alasdair and all,

> > To add a Tested-by tag, how much test do we actually need?
> > We've already done several tests of dm-ioband:
> > Proportional I/O bandwidth controlling
> > Loading/unloading driver and changing settings while under I/O load
> > Bounds checking of setting parameters
> > Benchmarks
> > Do you think these are enough for adding the tag?
> > It's very difficult for me to determine whether it's qualified or not.
> > It would be helpful if you could give me some advice.
>
> Interesting question... If it was me, I'd like to see exactly what
> you wrote above. State that you tested it and how you tested it. If
> there are a number of people who test it and the things they
> describe offer a broad spectrum of tests, I think that's helpful.
> Also, if extra testing is wanted, it can be suggested based on what
> tests have been performed.

I put the test items of dm-ioband on my website. This file requires
OpenOffice Calc to view.
http://people.valinux.co.jp/~ryov/dm-ioband/test/test-items.ods

Please also see the benchmark results at the following URL:
http://people.valinux.co.jp/~ryov/dm-ioband/benchmark/index.html

I would appreciate it very much if someone could give me some comments
and advices.

Thanks,
Ryo Tsuruta

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 02-23-2009, 06:16 AM
Ryo Tsuruta
 
Default Patchwork and patch flow

Hi Jonathan, Alasdair and all,

> > > To add a Tested-by tag, how much test do we actually need?
> > > We've already done several tests of dm-ioband:
> > > Proportional I/O bandwidth controlling
> > > Loading/unloading driver and changing settings while under I/O load
> > > Bounds checking of setting parameters
> > > Benchmarks
> > > Do you think these are enough for adding the tag?
> > > It's very difficult for me to determine whether it's qualified or not.
> > > It would be helpful if you could give me some advice.
> >
> > Interesting question... If it was me, I'd like to see exactly what
> > you wrote above. State that you tested it and how you tested it. If
> > there are a number of people who test it and the things they
> > describe offer a broad spectrum of tests, I think that's helpful.
> > Also, if extra testing is wanted, it can be suggested based on what
> > tests have been performed.
>
> I put the test items of dm-ioband on my website. This file requires
> OpenOffice Calc to view.
> http://people.valinux.co.jp/~ryov/dm-ioband/test/test-items.ods
>
> Please also see the benchmark results at the following URL:
> http://people.valinux.co.jp/~ryov/dm-ioband/benchmark/index.html

Could someone please review them and give me some comments?

Thanks,
Ryo Tsuruta

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 
Old 03-02-2009, 09:24 AM
Ryo Tsuruta
 
Default Patchwork and patch flow

Hi Jonathan, Alasdair and all,

> > > To add a Tested-by tag, how much test do we actually need?
> > > We've already done several tests of dm-ioband:
> > > Proportional I/O bandwidth controlling
> > > Loading/unloading driver and changing settings while under I/O load
> > > Bounds checking of setting parameters
> > > Benchmarks
> > > Do you think these are enough for adding the tag?
> > > It's very difficult for me to determine whether it's qualified or not.
> > > It would be helpful if you could give me some advice.
> >
> > Interesting question... If it was me, I'd like to see exactly what
> > you wrote above. State that you tested it and how you tested it. If
> > there are a number of people who test it and the things they
> > describe offer a broad spectrum of tests, I think that's helpful.
> > Also, if extra testing is wanted, it can be suggested based on what
> > tests have been performed.
>
> I put the test items of dm-ioband on my website. This file requires
> OpenOffice Calc to view.
> http://people.valinux.co.jp/~ryov/dm-ioband/test/test-items.ods
>
> Please also see the benchmark results at the following URL:
> http://people.valinux.co.jp/~ryov/dm-ioband/benchmark/index.html

I'm posting again this since nobody has answered yet.
I'm glad if someone can review the test items and give some comments.

Thanks,
Ryo Tsuruta

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 07:06 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org