FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Device-mapper Development

 
 
LinkBack Thread Tools
 
Old 12-05-2007, 06:37 PM
"Wood, Brian J"
 
Default add stripe end_io function and eventtrigger

Ah, ok. Thanks Mike I'll run that and repost. (Sorry for the error).



Brian Wood
Software Engineer
Intel Corp., Manageability & Platform Software Division
brian.j.wood@intel.com

>-----Original Message-----
>From: dm-devel-bounces@redhat.com [mailto:dm-devel-bounces@redhat.com]
On
>Behalf Of Mike Anderson
>Sent: Wednesday, December 05, 2007 9:57 AM
>To: device-mapper development
>Cc: Alasdair G Kergon
>Subject: Re: [dm-devel] [PATCH 1/2] add stripe end_io function and
>eventtrigger
>
>Wood, Brian J <brian.j.wood@intel.com> wrote:
>> +static void trigger_event(struct work_struct *work)
>> +{
>> + int i, len;
>> + char dev_path[DEV_STR_LEN];
>> + struct stripe_c *sc = container_of(work, struct stripe_c,
>> kstriped_ws);
>
>It appears your mailer is breaking lines which leads to hand edits
prior
>to trying to apply the patch.
>
>Your patch also appears to be adding extra whitespace. You want to run
>checkpatch.pl prior to sending the patch out and correct all issues
>listed.
>
>> + /* Finally as a last check, see if the inode mode is set
>>
>> + * to be a block device, record error if not */
>
>> + if (!S_ISBLK(inode->i_mode)) {
>> + atomic_inc(&(sc->stripe[i].error_count));
>> + }
>
>Code comment style and extra bracing.
>
>http://sources.redhat.com/lvm2/wiki/KernelPatchGuidelines
>
>
>-andmike
>--
>Michael Anderson
>andmike@linux.vnet.ibm.com
>
>--
>dm-devel mailing list
>dm-devel@redhat.com
>https://www.redhat.com/mailman/listinfo/dm-devel

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
 

Thread Tools




All times are GMT. The time now is 04:53 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org