Why doesn't SRPM compile?
 

version 11.4.0.65

yumdownloader --source --enablerepo=development anaconda
rpm -ivh anaconda-11.4.0.65*
cd /usr/src/redhat/SPECS
rpmbuild -bp anaconda.spec
cd /usr/src/redhat/BUILD/anaconda-11.4.0.65
make
.....

cc -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -Wall -Werror
-D_GNU_SOURCE=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1
-D_LARGEFILE64_SOURCE=1 -DUSESELINUX=1 -I/usr/include/libdhcp
-I/usr/include/dhcp4client -I/usr/include/dhcp6client -DUSE_LOGDEV
-DVERSION='"11.4.0.65"' -c -o nfsinstall.o nfsinstall.c

cc1: warnings being treated as errors
nfsinstall.c: In function 'nfsGetSetup':
nfsinstall.c:58: warning: assignment from incompatible pointer type
nfsinstall.c:61: warning: assignment from incompatible pointer type
make[1]: *** [nfsinstall.o] Error 1
make[1]: Leaving directory
`/usr/src/redhat/BUILD/anaconda-11.4.0.65/loader2'

make: *** [subdirs] Error 1

....

Am I missing something on my build system?
attached patches fix the issue for me, but the real question is why?


Jerry


--- net.c.orig 2008-04-05 13:26:38.000000000 -0500
+++ net.c 2008-04-05 13:29:56.000000000 -0500
@@ -269,8 +269,8 @@
"is needed, leave this field blank and the "
"install will continue."), ifname);
do {
- struct newtWinEntry entry[] = { { N_("ESSID"), &essid, 0 },
- { N_("Encryption Key"), &wepkey, 0 },
+ struct newtWinEntry entry[] = { { N_("ESSID"), (const char **)&essid, 0 },
+ { N_("Encryption Key"), (const char **) &wepkey, 0 },
{ NULL, NULL, 0 } };

rc = newtWinEntries(_("Wireless Settings"), buf,
@@ -307,7 +307,7 @@
int rc;
struct in_addr addr;
struct in6_addr addr6;
- char * ns = "";
+ const char * ns = "";
struct newtWinEntry entry[] = { { N_("Nameserver IP"), &ns, 0 },
{ NULL, NULL, 0 } };

diff -up ./nfsinstall.c.orig ./nfsinstall.c
--- ./nfsinstall.c.orig 2008-04-02 00:56:21.000000000 -0500
+++ ./nfsinstall.c 2008-04-05 13:21:54.000000000 -0500
@@ -55,10 +55,10 @@ int nfsGetSetup(char ** hostptr, char **
int rc;

entries[0].text = _("NFS server name:");
- entries[0].value = &newServer;
+ entries[0].value = (const char **) &newServer;
entries[0].flags = NEWT_FLAG_SCROLL;
rc = asprintf(&entries[1].text, _("%s directory:"), getProductName());
- entries[1].value = &newDir;
+ entries[1].value = (const char **) &newDir;
entries[1].flags = NEWT_FLAG_SCROLL;
entries[2].text = NULL;
entries[2].value = NULL;
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Why doesn't SRPM compile?
 

On Saturday, April 05 2008, Jerry Vonau said:
> Am I missing something on my build system?
> attached patches fix the issue for me, but the real question is why?

Newt changed what it wants as far as things being const or not in
newt-0.52.9. *sigh*

Jeremy

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Why doesn't SRPM compile?
 

Jeremy Katz wrote:

On Saturday, April 05 2008, Jerry Vonau said:

Am I missing something on my build system?
attached patches fix the issue for me, but the real question is why?


Newt changed what it wants as far as things being const or not in
newt-0.52.9. *sigh*

Jeremy


Ah, that makes sense now. Shouldn't the BuildRequires have newt-devel >=
0.52.9 rather than just newt-devel in the spec file then?


Jerry









_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list