FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian User

 
 
LinkBack Thread Tools
 
Old 05-13-2011, 04:25 PM
Ales Kozumplik
 
Default Fix cutting of the partiotion 'p' in getDiskPart().

On 05/13/2011 06:00 PM, Ales Kozumplik wrote:

Before it worked OK for 'mapper/mpath1p2' but it failed to separate the
partition part from 'mapper/rootdevp1' (because the disk part contains no
digits)

This replaces the ancient part of the method with something simpler and
hopefully more general (though it's hard to say it doesn't brake some
other cases).
---


This is yet another patch needed for 572862. Someone rhel5
storage-knowledgeable please review this. Thank you.


Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-17-2011, 10:46 AM
Ales Kozumplik
 
Default Fix cutting of the partiotion 'p' in getDiskPart().

On 05/16/2011 04:01 PM, Chris Lumens wrote:

Before it worked OK for 'mapper/mpath1p2' but it failed to separate the
partition part from 'mapper/rootdevp1' (because the disk part contains no
digits)

This replaces the ancient part of the method with something simpler and
hopefully more general (though it's hard to say it doesn't brake some
other cases).


The nice thing about this function is that it's completely standalone,
so it should be possible for you to whip up a pile of test cases and
verify that it works for old devices as well as for the things in this
bug.



I took the function out of the file and ran a couple of tests (mpath1,
mpath12p3, rootdev, etc.). Unfortunately I am not sure how to check
those in without including the mock machinery we have on rawhide. So
this has to do for now.


Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 07:25 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org