FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian User

 
 
LinkBack Thread Tools
 
Old 04-01-2011, 12:17 PM
Ales Kozumplik
 
Default nfs/kickstart: do not throw away the --opts part.

Anaconda can perfectly well parse the nfsptions:server:dir format, see
iutil.pyarseNfsUrl().

Resolves: rhbz#688757
---
loader/nfsinstall.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/loader/nfsinstall.c b/loader/nfsinstall.c
index 73dedcd..685062b 100644
--- a/loader/nfsinstall.c
+++ b/loader/nfsinstall.c
@@ -401,7 +401,8 @@ void setKickstartNfs(struct loaderData_s * loaderData, int argc,

substr = strstr(dir, ".img");
if (!substr || (substr && *(substr+4) != '')) {
- checked_asprintf(&(loaderData->instRepo), "nfs:%s:%s", host, dir);
+ checked_asprintf(&(loaderData->instRepo), "nfs:%s:%s:%s",
+ mountOpts, host, dir);

logMessage(INFO, "results of nfs, host is %s, dir is %s, opts are '%s'",
host, dir, mountOpts);
--
1.7.3.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 04-04-2011, 07:20 AM
Ales Kozumplik
 
Default nfs/kickstart: do not throw away the --opts part.

Anaconda can perfectly well parse the nfsptions:server:dir format, see
iutil.pyarseNfsUrl().
---
loader/nfsinstall.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/loader/nfsinstall.c b/loader/nfsinstall.c
index 73dedcd..c3019ce 100644
--- a/loader/nfsinstall.c
+++ b/loader/nfsinstall.c
@@ -401,7 +401,13 @@ void setKickstartNfs(struct loaderData_s * loaderData, int argc,

substr = strstr(dir, ".img");
if (!substr || (substr && *(substr+4) != '')) {
- checked_asprintf(&(loaderData->instRepo), "nfs:%s:%s", host, dir);
+ if (mountOpts) {
+ checked_asprintf(&(loaderData->instRepo), "nfs:%s:%s:%s",
+ mountOpts, host, dir);
+ } else {
+ checked_asprintf(&(loaderData->instRepo), "nfs:%s:%s",
+ host, dir);
+ }

logMessage(INFO, "results of nfs, host is %s, dir is %s, opts are '%s'",
host, dir, mountOpts);
--
1.7.3.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 04-04-2011, 02:31 PM
Chris Lumens
 
Default nfs/kickstart: do not throw away the --opts part.

> diff --git a/loader/nfsinstall.c b/loader/nfsinstall.c
> index 73dedcd..c3019ce 100644
> --- a/loader/nfsinstall.c
> +++ b/loader/nfsinstall.c
> @@ -401,7 +401,13 @@ void setKickstartNfs(struct loaderData_s * loaderData, int argc,
>
> substr = strstr(dir, ".img");
> if (!substr || (substr && *(substr+4) != '')) {
> - checked_asprintf(&(loaderData->instRepo), "nfs:%s:%s", host, dir);
> + if (mountOpts) {
> + checked_asprintf(&(loaderData->instRepo), "nfs:%s:%s:%s",
> + mountOpts, host, dir);
> + } else {
> + checked_asprintf(&(loaderData->instRepo), "nfs:%s:%s",
> + host, dir);
> + }
>
> logMessage(INFO, "results of nfs, host is %s, dir is %s, opts are '%s'",
> host, dir, mountOpts);

Looks good, thanks.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 11:51 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org