mpath: remove a harmful udev_trigger() in filter_gui
On 12/22/2010 05:22 AM, Ales Kozumplik wrote:
> Sometimes (race condition?) the udev_get_block_devices() call in getScreen() returns incomplete dictionaries for mpath devices. If ID_VENDOR is missing this causes a traceback in MPathCallbacks._populateUI().
>
> Related: rhbz#636570
> ---
> anaconda | 1 +
> iw/filter_gui.py | 1 -
> 2 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/anaconda b/anaconda
> index 0f9f88e..071442b 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -654,6 +654,7 @@ if __name__ == "__main__":
> # NetworkManager in the udev database
> from baseudev import udev_trigger, udev_settle
> udev_trigger("net")
> + udev_trigger("block") # trigger the block subsys too while at it
> udev_settle()
> # and for added fun, once doesn't seem to be enough? so we
> # do it twice, it works and we scream at the world "OH WHY?"
> diff --git a/iw/filter_gui.py b/iw/filter_gui.py
> index 98ae480..63655a0 100644
> --- a/iw/filter_gui.py
> +++ b/iw/filter_gui.py
> @@ -586,7 +586,6 @@ class FilterWindow(InstallWindow):
> self.store.set_sort_column_id(MODEL_COL, gtk.SORT_ASCENDING)
>
> anaconda.id.storage.devicetree.teardownAll()
> - udev_trigger(subsystem="block")
> # So that drives onlined by these show up in the filter UI
> storage.iscsi.iscsi().startup(anaconda.intf)
> storage.fcoe.fcoe().startup(anaconda.intf)
I wish we knew more of when this happens, but if this seems to solve
your problem, there's no real downside to doing it, so ACK.
--
Peter
Growth for the sake of growth is the ideology of the cancer cell.
01234567890123456789012345678901234567890123456789 012345678901234567890123456789
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
|
