Ack,

just one comment:

On 11/02/2010 09:44 PM, David Cantrell wrote:

+ if (g_mkdir_with_parents(file, 0755) == -1)
+ logMessage(ERROR, "mkdir error on %s: %m", file);
+
+ if (g_mkdir_with_parents(DD_MODULES, 0755) == -1)
+ logMessage(ERROR, "mkdir error on %s: %m", DD_MODULES);


Maybe we should have a function to call instead of g_mkdir_with_parents
that would both call g_mkdir_with_parents() and then do the logging.
Would save us some lines and ifs.


Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

On 11/09/2010 11:45 PM, David Cantrell wrote:

Replace uses of mkdirChain() with g_mkdir_with_parents() and
remove the existing mkdirChain() code from isys/imount.*

Added a wrapper function for g_mkdir_with_parents() usage.


This looks good now.

Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list