OK. Martin
----- "Hans de Goede" <hdegoede@redhat.com> wrote:

> The changes for the filtering UI and the whole disk formatting seem to
> have
> broken dmraid BIOS RAID support, the first traceback I hit while
> testing is
> due to DMRaidArrayDevice.__init__ now calling DMDevice.__init__ (was
> DiskDevice.__init__), and DMDevice.__init__ does not accept major and
> minor
> arguments. This changes DMDevice.__init__ to accept these arguments
> and
> pass them through to StorageDevice.__init__ .
>
> Note this likely does not completely fix 558440 but it is a necessary
> first
> step.
> ---
> storage/devices.py | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/storage/devices.py b/storage/devices.py
> index 800720a..4d1305d 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -1423,6 +1423,7 @@ class DMDevice(StorageDevice):
> _devDir = "/dev/mapper"
>
> def __init__(self, name, format=None, size=None, dmUuid=None,
> + major=None, minor=None,
> target=None, exists=None, parents=None,
> sysfsPath='):
> """ Create a DMDevice instance.
>
> @@ -1441,6 +1442,7 @@ class DMDevice(StorageDevice):
> exists -- indicates whether this is an existing
> device
> """
> StorageDevice.__init__(self, name, format=format, size=size,
> + major=major, minor=minor,
> exists=exists,
> parents=parents, sysfsPath=sysfsPath)
> self.target = target
> --
> 1.6.5.2
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

On Mon, 2010-01-25 at 13:22 +0100, Hans de Goede wrote:
> The changes for the filtering UI and the whole disk formatting seem to have
> broken dmraid BIOS RAID support, the first traceback I hit while testing is
> due to DMRaidArrayDevice.__init__ now calling DMDevice.__init__ (was
> DiskDevice.__init__), and DMDevice.__init__ does not accept major and minor
> arguments. This changes DMDevice.__init__ to accept these arguments and
> pass them through to StorageDevice.__init__ .

There is a reason DMDevice does not accept major/minor -- they can
change between activations, and are therefore unreliable. Are you sure
you need to pass them in at all?

Dave

>
> Note this likely does not completely fix 558440 but it is a necessary first
> step.
> ---
> storage/devices.py | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/storage/devices.py b/storage/devices.py
> index 800720a..4d1305d 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -1423,6 +1423,7 @@ class DMDevice(StorageDevice):
> _devDir = "/dev/mapper"
>
> def __init__(self, name, format=None, size=None, dmUuid=None,
> + major=None, minor=None,
> target=None, exists=None, parents=None, sysfsPath='):
> """ Create a DMDevice instance.
>
> @@ -1441,6 +1442,7 @@ class DMDevice(StorageDevice):
> exists -- indicates whether this is an existing device
> """
> StorageDevice.__init__(self, name, format=format, size=size,
> + major=major, minor=minor,
> exists=exists,
> parents=parents, sysfsPath=sysfsPath)
> self.target = target


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list