FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian User

 
 
LinkBack Thread Tools
 
Old 01-21-2010, 03:01 PM
Hans de Goede
 
Default When in simple mode show BIOS RAID sets in basic page

OEM's routinely ship systems with BIOS RAID enabled, so we should support
these in basic mode to.
---
iw/filter_gui.py | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/iw/filter_gui.py b/iw/filter_gui.py
index 6145cd4..58d1acb 100644
--- a/iw/filter_gui.py
+++ b/iw/filter_gui.py
@@ -145,6 +145,10 @@ class Callbacks(object):
return self.isMember(model.get_value(iter, OBJECT_COL)) and
model.get_value(iter, 1)

+class SimpleCallbacks(Callbacks):
+ def isMember(self, info):
+ return info and not isMultipath(info) and not isOther(info)
+
class RAIDCallbacks(Callbacks):
def isMember(self, info):
return info and (isRAID(info) or isCCISS(info))
@@ -406,8 +410,8 @@ class FilterWindow(InstallWindow):
self._cachedMPaths.extend(mpaths)
self._cachedRaidDevices.extend(raids)

- def _makeBasic(self):
- np = NotebookPage(self.store, "basic", self.xml, Callbacks(self.xml))
+ def _makeBasic(self, callbacks):
+ np = NotebookPage(self.store, "basic", self.xml, callbacks(self.xml))

np.ds.addColumn(_("Model"), MODEL_COL)
np.ds.addColumn(_("Capacity"), CAPACITY_COL)
@@ -505,11 +509,11 @@ class FilterWindow(InstallWindow):
self.store.set_sort_column_id(MODEL_COL, gtk.SORT_ASCENDING)

if anaconda.id.simpleFilter:
- self.pages = [self._makeBasic()]
+ self.pages = [self._makeBasic(SimpleCallbacks)]
self.notebook.set_show_border(False)
self.notebook.set_show_tabs(False)
else:
- self.pages = [self._makeBasic(), self._makeRAID(),
+ self.pages = [self._makeBasic(Callbacks), self._makeRAID(),
self._makeMPath(), self._makeOther(),
self._makeSearch()]

--
1.6.5.2

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-21-2010, 04:55 PM
Hans de Goede
 
Default When in simple mode show BIOS RAID sets in basic page

Hi,

On 01/21/2010 07:47 PM, Chris Lumens wrote:

OEM's routinely ship systems with BIOS RAID enabled, so we should support
these in basic mode to.


I really dislike this - you're redefining what "basic" means, basically
saying "it doesn't matter whether you chose basic or not, you're still
getting RAID devices to look at."


Erm no I'm redefining what simple means, note that there are no tabs in simple mode
so the word "Basic" is not used.

Also quoting from the screen where one can choose simple or complex storage:

self.buttonGroup.addEntry("simple", _("Basic Storage Devices"),
descr=_("Installs or upgrades to typical types "
"of storage devices. If you're not sure "
"which option is right for you, this is "
"probably it."))
self.buttonGroup.addEntry("complex", _("Specialized Storage Devices"),
descr=_("Installs or upgrades to devices such as "
"Storage Area Networks (SANs) or mainframe
"attached disks (DASD), usually in an "
"enterprise environment"))

Notice that simple is for "typical types of storage", and BIOS RAID is
quit common, iow typical. It surely is not:
"Storage Area Networks (SANs) or mainframe attached disks (DASD)"


@@ -406,8 +410,8 @@ class FilterWindow(InstallWindow):
self._cachedMPaths.extend(mpaths)
self._cachedRaidDevices.extend(raids)

- def _makeBasic(self):
- np = NotebookPage(self.store, "basic", self.xml, Callbacks(self.xml))
+ def _makeBasic(self, callbacks):
+ np = NotebookPage(self.store, "basic", self.xml, callbacks(self.xml))

np.ds.addColumn(_("Model"), MODEL_COL)
np.ds.addColumn(_("Capacity"), CAPACITY_COL)
@@ -505,11 +509,11 @@ class FilterWindow(InstallWindow):
self.store.set_sort_column_id(MODEL_COL, gtk.SORT_ASCENDING)

if anaconda.id.simpleFilter:
- self.pages = [self._makeBasic()]
+ self.pages = [self._makeBasic(SimpleCallbacks)]
self.notebook.set_show_border(False)
self.notebook.set_show_tabs(False)
else:
- self.pages = [self._makeBasic(), self._makeRAID(),
+ self.pages = [self._makeBasic(Callbacks), self._makeRAID(),
self._makeMPath(), self._makeOther(),
self._makeSearch()]


Please preserve the fact that right now, all _makeWhatever methods take
the same number of arguments.



Done, new patch coming up.

Regards,

Hans


p.s.

Is there any reason why the screen is the first screen after the welcome screen,
IMHO it should be directly before the partition type screen, so after the
root pass one. This makes it easier to go back when you find out you forgot to
check some disk you want, and it feels more logical to group all the storage
screens together.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-21-2010, 04:56 PM
Hans de Goede
 
Default When in simple mode show BIOS RAID sets in basic page

OEM's routinely ship systems with BIOS RAID enabled, so we should support
these in basic mode to.
---
iw/filter_gui.py | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/iw/filter_gui.py b/iw/filter_gui.py
index 6145cd4..a927e1e 100644
--- a/iw/filter_gui.py
+++ b/iw/filter_gui.py
@@ -145,6 +145,10 @@ class Callbacks(object):
return self.isMember(model.get_value(iter, OBJECT_COL)) and
model.get_value(iter, 1)

+class SimpleCallbacks(Callbacks):
+ def isMember(self, info):
+ return info and not isMultipath(info) and not isOther(info)
+
class RAIDCallbacks(Callbacks):
def isMember(self, info):
return info and (isRAID(info) or isCCISS(info))
@@ -407,7 +411,12 @@ class FilterWindow(InstallWindow):
self._cachedRaidDevices.extend(raids)

def _makeBasic(self):
- np = NotebookPage(self.store, "basic", self.xml, Callbacks(self.xml))
+ if self.anaconda.id.simpleFilter:
+ np = NotebookPage(self.store, "basic", self.xml,
+ SimpleCallbacks(self.xml))
+ else:
+ np = NotebookPage(self.store, "basic", self.xml,
+ Callbacks(self.xml))

np.ds.addColumn(_("Model"), MODEL_COL)
np.ds.addColumn(_("Capacity"), CAPACITY_COL)
--
1.6.5.2

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-21-2010, 05:47 PM
Chris Lumens
 
Default When in simple mode show BIOS RAID sets in basic page

> OEM's routinely ship systems with BIOS RAID enabled, so we should support
> these in basic mode to.

I really dislike this - you're redefining what "basic" means, basically
saying "it doesn't matter whether you chose basic or not, you're still
getting RAID devices to look at." It further means that if you bounce
back and forth between basic and advanced, RAID devices will move from
one tab to another. That's really not very easy to explain to a user.

> @@ -406,8 +410,8 @@ class FilterWindow(InstallWindow):
> self._cachedMPaths.extend(mpaths)
> self._cachedRaidDevices.extend(raids)
>
> - def _makeBasic(self):
> - np = NotebookPage(self.store, "basic", self.xml, Callbacks(self.xml))
> + def _makeBasic(self, callbacks):
> + np = NotebookPage(self.store, "basic", self.xml, callbacks(self.xml))
>
> np.ds.addColumn(_("Model"), MODEL_COL)
> np.ds.addColumn(_("Capacity"), CAPACITY_COL)
> @@ -505,11 +509,11 @@ class FilterWindow(InstallWindow):
> self.store.set_sort_column_id(MODEL_COL, gtk.SORT_ASCENDING)
>
> if anaconda.id.simpleFilter:
> - self.pages = [self._makeBasic()]
> + self.pages = [self._makeBasic(SimpleCallbacks)]
> self.notebook.set_show_border(False)
> self.notebook.set_show_tabs(False)
> else:
> - self.pages = [self._makeBasic(), self._makeRAID(),
> + self.pages = [self._makeBasic(Callbacks), self._makeRAID(),
> self._makeMPath(), self._makeOther(),
> self._makeSearch()]

Please preserve the fact that right now, all _makeWhatever methods take
the same number of arguments.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-21-2010, 07:35 PM
Chris Lumens
 
Default When in simple mode show BIOS RAID sets in basic page

> >>OEM's routinely ship systems with BIOS RAID enabled, so we should support
> >>these in basic mode to.
> >
> >I really dislike this - you're redefining what "basic" means, basically
> >saying "it doesn't matter whether you chose basic or not, you're still
> >getting RAID devices to look at."
>
> Erm no I'm redefining what simple means, note that there are no tabs in simple mode
> so the word "Basic" is not used.

You know what I meant. Having written this screen, I am aware of where
there are and are not tabs.

What you see on the simple screen is the Basic tab from the advanced
screen.

> Also quoting from the screen where one can choose simple or complex storage:
>
> self.buttonGroup.addEntry("simple", _("Basic Storage Devices"),
> descr=_("Installs or upgrades to typical types "
> "of storage devices. If you're not sure "
> "which option is right for you, this is "
> "probably it."))
> self.buttonGroup.addEntry("complex", _("Specialized Storage Devices"),
> descr=_("Installs or upgrades to devices such as "
> "Storage Area Networks (SANs) or mainframe
> "attached disks (DASD), usually in an "
> "enterprise environment"))
>
> Notice that simple is for "typical types of storage", and BIOS RAID is
> quit common, iow typical. It surely is not:
> "Storage Area Networks (SANs) or mainframe attached disks (DASD)"

Then perhaps the text there needs to be changed.

You did not address my biggest complaint, which is that this patch will
cause biosraid devices to appear in one place on the simple screen and a
completely different place on the advanced screen. And, you know people
are going to go back and forth between the two to see what exciting
feature they are missing.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-22-2010, 02:41 PM
Hans de Goede
 
Default When in simple mode show BIOS RAID sets in basic page

Hi,

On 01/22/2010 04:35 PM, Hans de Goede wrote:

> >>OEM's routinely ship systems with BIOS RAID enabled, so we should
support
> >>these in basic mode to.
> >
> >I really dislike this - you're redefining what "basic" means, basically
> >saying "it doesn't matter whether you chose basic or not, you're still
> >getting RAID devices to look at."
>
> Erm no I'm redefining what simple means, note that there are no tabs
in simple mode
> so the word "Basic" is not used.

You know what I meant. Having written this screen, I am aware of where
there are and are not tabs.

What you see on the simple screen is the Basic tab from the advanced
screen.

> Also quoting from the screen where one can choose simple or complex
storage:
>
> self.buttonGroup.addEntry("simple", _("Basic Storage Devices"),
> descr=_("Installs or upgrades to typical types "
> "of storage devices. If you're not sure "
> "which option is right for you, this is "
> "probably it."))
> self.buttonGroup.addEntry("complex", _("Specialized Storage Devices"),
> descr=_("Installs or upgrades to devices such as "
> "Storage Area Networks (SANs) or mainframe
> "attached disks (DASD), usually in an "
> "enterprise environment"))
>
> Notice that simple is for "typical types of storage", and BIOS RAID is
> quit common, iow typical. It surely is not:
> "Storage Area Networks (SANs) or mainframe attached disks (DASD)"

Then perhaps the text there needs to be changed.

You did not address my biggest complaint, which is that this patch will
cause biosraid devices to appear in one place on the simple screen and a
completely different place on the advanced screen. And, you know people
are going to go back and forth between the two to see what exciting
feature they are missing.



The way I see this is:

In the simple screen people get a single list (no tabs), and
in the advanced screen people get the disks divided over multiple tabs,
so naturally some of them may be on a different tab.

I must say though I wonder (a bit late I guess, but this is the first
time I'm actually playing around with the new code) what the use is of
the simple screen is at all. Filtering was added for the big iron case,
why not "simply" skip it when doing simple configuration and leave
exclusiveDisks empty (thus showing all disks later as we did before).

This would also reduce the number of screens shown in a simple install,
which I think would be a good thing. The new code replaces a single
screen in the old code with 4 new screens.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-25-2010, 03:25 PM
Chris Lumens
 
Default When in simple mode show BIOS RAID sets in basic page

> In the simple screen people get a single list (no tabs), and
> in the advanced screen people get the disks divided over multiple tabs,
> so naturally some of them may be on a different tab.
>
> I must say though I wonder (a bit late I guess, but this is the first
> time I'm actually playing around with the new code) what the use is of
> the simple screen is at all. Filtering was added for the big iron case,
> why not "simply" skip it when doing simple configuration and leave
> exclusiveDisks empty (thus showing all disks later as we did before).

The simple screen is there for people who may have several disks and
want some assurance that anaconda's not going to screw around with them
at all. It's yet another thing to help people feel better that we won't
destroy their data on some non-installation drive. The simple screen
does not just put all device types into a single view - it only deals
with regular disks.

I have some ideas for how to trim down the number of screens that the
average home user will see, but they require dispatcher work that I
don't yet have time for.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-26-2010, 11:17 AM
Hans de Goede
 
Default When in simple mode show BIOS RAID sets in basic page

Hi,

On 01/25/2010 05:25 PM, Chris Lumens wrote:

In the simple screen people get a single list (no tabs), and
in the advanced screen people get the disks divided over multiple tabs,
so naturally some of them may be on a different tab.

I must say though I wonder (a bit late I guess, but this is the first
time I'm actually playing around with the new code) what the use is of
the simple screen is at all. Filtering was added for the big iron case,
why not "simply" skip it when doing simple configuration and leave
exclusiveDisks empty (thus showing all disks later as we did before).


The simple screen is there for people who may have several disks and
want some assurance that anaconda's not going to screw around with them
at all. It's yet another thing to help people feel better that we won't
destroy their data on some non-installation drive. The simple screen
does not just put all device types into a single view - it only deals
with regular disks.



I'm not saying that all devices should be there in a single view, what
I'm saying is that since it is only a single view, it is not strange
for it to have more devices there, then that will be listed in
the Basic tab in the non single view.

And I still believe that BIOS RAID sets should be listed in the
Simple screen single view. Let me put it this way, if ubuntu supports
in its pretty basic installer, it should be in the Simple screen.

BIOS RAID is even used in (gaming) laptops, it is not like this is
some sort of exotic server technology like iscsi, fcoe or mpath.


I have some ideas for how to trim down the number of screens that the
average home user will see, but they require dispatcher work that I
don't yet have time for.



Good.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 09:31 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org