FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian User

 
 
LinkBack Thread Tools
 
Old 02-21-2009, 02:00 AM
David Cantrell
 
Default rhel5-branch Fix for traceback in Partitions.doMetaDeletes.addSnap() (#433824)

Traceback (most recent call first):
File "/usr/lib/anaconda/partitions.py", line 1372, in addSnap
snaps = snapshots[name]
File "/usr/lib/anaconda/partitions.py", line 1383, in doMetaDeletes
addSnap(delete.name, delete.vg)
File "/usr/lib/anaconda/packages.py", line 144, in turnOnFilesystems
anaconda.id.partitions.doMetaDeletes(anaconda.id.d iskset)
File "/usr/lib/anaconda/dispatch.py", line 201, in moveStep
rc = stepFunc(self.anaconda)
File "/usr/lib/anaconda/dispatch.py", line 124, in gotoNext
self.moveStep()
File "/usr/lib/anaconda/gui.py", line 1018, in nextClicked
self.anaconda.dispatch.gotoNext()
File "/usr/lib/anaconda/iw/progress_gui.py", line 243, in renderCallback
self.intf.icw.nextClicked()
File "/usr/lib/anaconda/gui.py", line 1045, in handleRenderCallback
self.currentWindow.renderCallback()
KeyError: 'data'
---
partitions.py | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/partitions.py b/partitions.py
index 47ae4df..f2292dc 100644
--- a/partitions.py
+++ b/partitions.py
@@ -1599,6 +1599,8 @@ class Partitions:
lvm_parent_deletes = []
tmp = {}
def addSnap(name, vg):
+ if not snapshots.has_key(name):
+ return
snaps = snapshots[name]
for snap, snapvg in snaps:
addSnap(snap, snapvg)
--
1.6.1.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 02-23-2009, 08:39 AM
Joel Granados
 
Default rhel5-branch Fix for traceback in Partitions.doMetaDeletes.addSnap() (#433824)

The patch looks ok.

Just out of curiousity: I'm wondering why the trace back says line 1372 and
the patch is on line 1599. Do you have the bug number?

Regards

On Fri, Feb 20, 2009 at 05:00:23PM -1000, David Cantrell wrote:
> Traceback (most recent call first):
> File "/usr/lib/anaconda/partitions.py", line 1372, in addSnap
> snaps = snapshots[name]
> File "/usr/lib/anaconda/partitions.py", line 1383, in doMetaDeletes
> addSnap(delete.name, delete.vg)
> File "/usr/lib/anaconda/packages.py", line 144, in turnOnFilesystems
> anaconda.id.partitions.doMetaDeletes(anaconda.id.d iskset)
> File "/usr/lib/anaconda/dispatch.py", line 201, in moveStep
> rc = stepFunc(self.anaconda)
> File "/usr/lib/anaconda/dispatch.py", line 124, in gotoNext
> self.moveStep()
> File "/usr/lib/anaconda/gui.py", line 1018, in nextClicked
> self.anaconda.dispatch.gotoNext()
> File "/usr/lib/anaconda/iw/progress_gui.py", line 243, in renderCallback
> self.intf.icw.nextClicked()
> File "/usr/lib/anaconda/gui.py", line 1045, in handleRenderCallback
> self.currentWindow.renderCallback()
> KeyError: 'data'
> ---
> partitions.py | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/partitions.py b/partitions.py
> index 47ae4df..f2292dc 100644
> --- a/partitions.py
> +++ b/partitions.py
> @@ -1599,6 +1599,8 @@ class Partitions:
> lvm_parent_deletes = []
> tmp = {}
> def addSnap(name, vg):
> + if not snapshots.has_key(name):
> + return
> snaps = snapshots[name]
> for snap, snapvg in snaps:
> addSnap(snap, snapvg)
> --
> 1.6.1.3
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

--
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 02-23-2009, 06:54 PM
David Cantrell
 
Default rhel5-branch Fix for traceback in Partitions.doMetaDeletes.addSnap() (#433824)

Joel Granados wrote:

The patch looks ok.

Just out of curiousity: I'm wondering why the trace back says line 1372 and
the patch is on line 1599. Do you have the bug number?


Bug number is 433824

addSnap() only lives around 1599 now, and since this report was
originally against RHEL 5.1, my guess is we evolved partitions.py enough
to shift that function down to 1599.




Regards

On Fri, Feb 20, 2009 at 05:00:23PM -1000, David Cantrell wrote:

Traceback (most recent call first):
File "/usr/lib/anaconda/partitions.py", line 1372, in addSnap
snaps = snapshots[name]
File "/usr/lib/anaconda/partitions.py", line 1383, in doMetaDeletes
addSnap(delete.name, delete.vg)
File "/usr/lib/anaconda/packages.py", line 144, in turnOnFilesystems
anaconda.id.partitions.doMetaDeletes(anaconda.id.d iskset)
File "/usr/lib/anaconda/dispatch.py", line 201, in moveStep
rc = stepFunc(self.anaconda)
File "/usr/lib/anaconda/dispatch.py", line 124, in gotoNext
self.moveStep()
File "/usr/lib/anaconda/gui.py", line 1018, in nextClicked
self.anaconda.dispatch.gotoNext()
File "/usr/lib/anaconda/iw/progress_gui.py", line 243, in renderCallback
self.intf.icw.nextClicked()
File "/usr/lib/anaconda/gui.py", line 1045, in handleRenderCallback
self.currentWindow.renderCallback()
KeyError: 'data'
---
partitions.py | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/partitions.py b/partitions.py
index 47ae4df..f2292dc 100644
--- a/partitions.py
+++ b/partitions.py
@@ -1599,6 +1599,8 @@ class Partitions:
lvm_parent_deletes = []
tmp = {}
def addSnap(name, vg):
+ if not snapshots.has_key(name):
+ return
snaps = snapshots[name]
for snap, snapvg in snaps:
addSnap(snap, snapvg)
--
1.6.1.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list





--
David Cantrell <dcantrell@redhat.com>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 02:42 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org