Hi All,

As $SUBJECT says:

iw/netconfig_dialog.py:176: No class attribute (_handleIPMissing) found
iw/netconfig_dialog.py:193: No class attribute (_handleIPMissing) found
iw/netconfig_dialog.py:201: No class attribute (_handleIPMissing) found
network.py:346: No global (anaconda) found
partedUtils.py:315: No global (device) found
text.py:262: No global (MessageWindow) found
text.py:413: Invalid arguments to (exceptionWindow), got 1, expected 2
textw/network_text.py:238: Object (ptpaddr) has no attribute (value)
textw/network_text.py:239: Object (ptpaddr) has no attribute (value)

Might be false positive, but probably real issue
text.py:475: No global (instkey) found

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

> text.py:262: No global (MessageWindow) found

Patch attached.
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

On Mon, Nov 03, 2008 at 03:38:55PM +0100, Hans de Goede wrote:
> textw/network_text.py:238: Object (ptpaddr) has no attribute (value)
> textw/network_text.py:239: Object (ptpaddr) has no attribute (value)

This one is referencing ptpaddr, which is incorrectly set up as ptplist in the
code. Here's the fix:

diff --git a/textw/network_text.py b/textw/network_text.py
index 76efc39..773ff56 100644
--- a/textw/network_text.py
+++ b/textw/network_text.py
@@ -163,9 +163,9 @@ class NetworkDeviceWindow:
if isPtp:
ipmiscgrid.setField(Label(_("P-to-P:")), 0, ipmiscrow,
anchorLeft = 1, padding = (0, 1, 1, 0))
- ptplist = Entry(41)
- ptplist.set(dev.get('remip'))
- ipmiscgrid.setField(ptplist, 1, ipmiscrow, anchorLeft = 1,
+ ptpaddr = Entry(41)
+ ptpaddr.set(dev.get('remip'))
+ ipmiscgrid.setField(ptpaddr, 1, ipmiscrow, anchorLeft = 1,
padding = (0, 1, 0, 0))

ipmiscrow += 1


--
David Cantrell <dcantrell@redhat.com>
Red Hat / Honolulu, HI
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

On Mon, Nov 03, 2008 at 03:38:55PM +0100, Hans de Goede wrote:
> iw/netconfig_dialog.py:176: No class attribute (_handleIPMissing) found
> iw/netconfig_dialog.py:193: No class attribute (_handleIPMissing) found
> iw/netconfig_dialog.py:201: No class attribute (_handleIPMissing) found

For whatever reason, _handleIPMissing() in netconfig_dialog.py was, well,
missing. It's in the equivalent textw file, so copied the dialog strings
from there and made a gtk function here to pop up the message about missing
information.

diff --git a/iw/netconfig_dialog.py b/iw/netconfig_dialog.py
index a3f1626..146be11 100644
--- a/iw/netconfig_dialog.py
+++ b/iw/netconfig_dialog.py
@@ -131,6 +131,14 @@ class NetworkConfigurator:
def destroy(self):
self.window.destroy()

+ def _handleIPMissing(screen, field):
+ d = gtk.MessageDialog(_("Error With Data"), 0, gtk.MESSAGE_ERROR,
+ gtk.BUTTONS_OK,
+ _("A value is required for the field %s.")
+ % (field,))
+ d.run()
+ d.destroy()
+
def _handleIPError(self, field, errmsg):
d = gtk.MessageDialog(_("Error With Data"), 0, gtk.MESSAGE_ERROR,
gtk.BUTTONS_OK,

--
David Cantrell <dcantrell@redhat.com>
Red Hat / Honolulu, HI
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Just to compare a bit, my check with pylint (0.13.2) didn't find
following real issues:

text.py:413: Invalid arguments to (exceptionWindow), got 1, expected 2
textw/network_text.py:238: Object (ptpaddr) has no attribute (value)
textw/network_text.py:239: Object (ptpaddr) has no attribute (value)

I don't think that it was caused by badly set environment, or not giving
some options, or use of older version (see example), so from this point
of view (real issues found), pychecker seems as a good choice.

Radek

[rvykydal@dhcp-lab-119 pylint]$ cat ./test2.py

#!/usr/bin/env pyhton

def f(a, b):
pass

if False:
f('a')

def g():
v = None
if False:
print v.value()
[rvykydal@dhcp-lab-119 pylint]$ pychecker ./test2.py
Processing test2...

Warnings...

test2.py:8: Invalid arguments to (f), got 1, expected 2
test2.py:13: Object (v) has no attribute (value)
[rvykydal@dhcp-lab-119 pylint]$ pylint -r n ./test2.py
************* Module test2
C0111: 1: Missing docstring
C0103: 4:f: Invalid name "f" (should match [a-z_][a-z0-9_]{2,30}$)
C0111: 4:f: Missing docstring
C0103: 4:f: Invalid name "a" (should match [a-z_][a-z0-9_]{2,30}$)
C0103: 4:f: Invalid name "b" (should match [a-z_][a-z0-9_]{2,30}$)
W0613: 4:f: Unused argument 'a'
W0613: 4:f: Unused argument 'b'
C0103: 10:g: Invalid name "g" (should match [a-z_][a-z0-9_]{2,30}$)
C0111: 10:g: Missing docstring
C0103: 11:g: Invalid name "v" (should match [a-z_][a-z0-9_]{2,30}$)
[rvykydal@dhcp-lab-119 pylint]$ rpm -qv pychecker
pychecker-0.8.17-2
[rvykydal@dhcp-lab-119 pylint]$ rpm -qv pylint
pylint-0.13.2-1.fc8

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Radek Vykydal wrote:
Just to compare a bit, my check with pylint (0.13.2) didn't find
following real issues:

text.py:413: Invalid arguments to (exceptionWindow), got 1, expected 2
textw/network_text.py:238: Object (ptpaddr) has no attribute (value)
textw/network_text.py:239: Object (ptpaddr) has no attribute (value)

I don't think that it was caused by badly set environment, or not giving
some options, or use of older version (see example), so from this point
of view (real issues found), pychecker seems as a good choice.



Cool,

Thanks for the testing.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list