FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Laptop

 
 
LinkBack Thread Tools
 
Old 11-06-2008, 03:41 PM
Hans de Goede
 
Default PATCH: kickstart, iscsi do not call iscsi.startup after startIBFT has been called

Hi All,

The current kickstart IscsiName code calls iscsi.startup after calling
iscsi.startIBFT, but startIBFT will call iscsi.addTarget when an IBFT target
is found, which will in turn then call iscsi.startup. iscsi.startup is not
protected against being called twice, and currently doing so happens to not
have adverse side effects, but we really should not be relying on that.

Note: when no IBFT target is found there is no reason to call iscsi.startup

Regards,

Hans
>From 67ea62855a5a6e23335d0536bfefab34d35a0d71 Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@redhat.com>
Date: Thu, 6 Nov 2008 17:36:35 +0100
Subject: [PATCH] kickstart, iscsi do not call iscsi.startup after startIBFT has been called

The current kickstart IscsiName code calls iscsi.startup after calling
iscsi.startIBFT, but startIBFT will call iscsi.addTarget when an IBFT target
is found, which will in turn then call iscsi.startup. iscsi.startup is not
protected against being called twice, and currently doing so happens to not
have adverse side effects, but we really should not be relying on that.

Note: when no IBFT target is found there is no reason to call iscsi.startup
---
kickstart.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kickstart.py b/kickstart.py
index af2e063..ef9488b 100644
--- a/kickstart.py
+++ b/kickstart.py
@@ -298,7 +298,6 @@ class IscsiName(commands.iscsiname.FC6_IscsiName):

self.handler.id.iscsi.initiator = self.iscsiname
self.handler.id.iscsi.startIBFT()
- self.handler.id.iscsi.startup()
# FIXME: flush the drive dict so we figure drives out again
isys.flushDriveDict()

--
1.6.0.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 11:48 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org