Bug#479899: linux-libc-dev: missing include in netfilter.h

05-07-2008, 08:22 AM

Package: linux-libc-dev
Version: 2.6.25-1
Severity: serious

Hi,

It seems like netfilter.h should include linux/types.h. In 2.6.25-1, the
following was added to it:
> enum nf_inet_hooks {
> NF_INET_PRE_ROUTING,
> NF_INET_LOCAL_IN,
> NF_INET_FORWARD,
> NF_INET_LOCAL_OUT,
> NF_INET_POST_ROUTING,
> NF_INET_NUMHOOKS
> };
>
> union nf_inet_addr {
> __u32 all[4];
> __be32 ip;
> __be32 ip6[4];
> struct in_addr in;
> struct in6_addr in6;
> };

Leading to build failures of a few packages, including transproxy:
gcc -O2 -Wall -DDNS_LOOKUPS -DLOG_FAULTS_TO_SYSLOG -DLOG_TO_FILE
-DLOG_TO_FILE_LINEBUFF -DIPTABLES -DTCP_WRAPPERS -c tproxy.c -o tproxy.o
In file included from /usr/include/linux/netfilter_ipv4.h:8,
from tproxy.c:53:
/usr/include/linux/netfilter.h:40: error: expected specifier-qualifier-list before '__u32'
--
| Lucas Nussbaum
| lucas@lucas-nussbaum.net http://www.lucas-nussbaum.net/ |
| jabber: lucas@nussbaum.fr GPG: 1024D/023B3F4F |

--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

05-07-2008, 09:09 AM

severity 479899 normal
thanks

On Wed, May 07, 2008 at 10:22:55AM +0200, Lucas Nussbaum wrote:
> It seems like netfilter.h should include linux/types.h. In 2.6.25-1, the
> following was added to it:

Linux headers are not self-hosting. Anyway, it makes it not completely
unusable.

Bastian

--
Each kiss is as the first.
-- Miramanee, Kirk's wife, "The Paradise Syndrome",
stardate 4842.6

--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

05-07-2008, 10:24 AM

On 07/05/08 at 11:09 +0200, Bastian Blank wrote:
> severity 479899 normal
> thanks
>
> On Wed, May 07, 2008 at 10:22:55AM +0200, Lucas Nussbaum wrote:
> > It seems like netfilter.h should include linux/types.h. In 2.6.25-1, the
> > following was added to it:
>
> Linux headers are not self-hosting. Anyway, it makes it not completely
> unusable.

But several packages now FTBFS. Do you plan to fix that bug? Or should I
file serious bugs on the failing packages?
--
| Lucas Nussbaum
| lucas@lucas-nussbaum.net http://www.lucas-nussbaum.net/ |
| jabber: lucas@nussbaum.fr GPG: 1024D/023B3F4F |

--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

05-23-2008, 07:38 AM

On 07/05/08 at 12:24 +0200, Lucas Nussbaum wrote:
> On 07/05/08 at 11:09 +0200, Bastian Blank wrote:
> > severity 479899 normal
> > thanks
> >
> > On Wed, May 07, 2008 at 10:22:55AM +0200, Lucas Nussbaum wrote:
> > > It seems like netfilter.h should include linux/types.h. In 2.6.25-1, the
> > > following was added to it:
> >
> > Linux headers are not self-hosting. Anyway, it makes it not completely
> > unusable.
>
> But several packages now FTBFS. Do you plan to fix that bug? Or should I
> file serious bugs on the failing packages?

Hi,

This was fixed upstream, see http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c8942f1f0a7e2160ebf2e51ba89e50e e5895a1e7

Please backport this change, so I don't need to file 8 more RC bugs....
:-)
--
| Lucas Nussbaum
| lucas@lucas-nussbaum.net http://www.lucas-nussbaum.net/ |
| jabber: lucas@nussbaum.fr GPG: 1024D/023B3F4F |

--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org