Package: linux
Version: 3.2.23-1
Severity: important
Tags: patch

Hello,

The following patch has been applied to greg's staging tree, it would be
important to get it into Wheezy, as it noticeably improves usability for
blind users.

Samuel

>From cfd757010691eae4e17acc246f74e7622c3a2f05 Mon Sep 17 00:00:00 2001
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Sun, 26 Aug 2012 23:35:17 +0200
Subject: speakup: lower default software speech rate

Speech synthesis beginners need a low speech rate, and trained people
want a high speech rate. A medium speech rate is thus actually not a
good default for neither. Since trained people will typically know how
to change the rate, better default for a low speech rate, which
beginners can grasp and learn how to increase it afterwards

This was agreed with users on the speakup mailing list.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/speakup/speakup_soft.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/speakup_soft.c b/drivers/staging/speakup/speakup_soft.c
index 42cdafe..2a67610 100644
--- a/drivers/staging/speakup/speakup_soft.c
+++ b/drivers/staging/speakup/speakup_soft.c
@@ -46,7 +46,7 @@ static int misc_registered;
static struct var_t vars[] = {
{ CAPS_START, .u.s = {"x01+3p" } },
{ CAPS_STOP, .u.s = {"x01-3p" } },
- { RATE, .u.n = {"x01%ds", 5, 0, 9, 0, 0, NULL } },
+ { RATE, .u.n = {"x01%ds", 2, 0, 9, 0, 0, NULL } },
{ PITCH, .u.n = {"x01%dp", 5, 0, 9, 0, 0, NULL } },
{ VOL, .u.n = {"x01%dv", 5, 0, 9, 0, 0, NULL } },
{ TONE, .u.n = {"x01%dx", 1, 0, 2, 0, 0, NULL } },
--
1.7.10.130.g36e6c


--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20120905083350.GA9061@type.bordeaux.inria.fr">http ://lists.debian.org/20120905083350.GA9061@type.bordeaux.inria.fr

On Wed, 2012-09-05 at 10:33 +0200, Samuel Thibault wrote:
> Package: linux
> Version: 3.2.23-1
> Severity: important
> Tags: patch
>
> Hello,
>
> The following patch has been applied to greg's staging tree, it would be
> important to get it into Wheezy, as it noticeably improves usability for
> blind users.
[...]

OK, I will do.

But I looked at what exactly is done with this 'vars' table and... it
looks really nasty. This goes into an initialisation string which will
be the first thing the userland synthesiser gets when it reads the
softsynth char device, right?

However:
1. The last character of the init string will be repeated.
2. If the read() caller doesn't provide a big enough buffer for the init
string, the next read() will get it again from the start, so it can
never make progress.

Would you be able to test the attached patch, that should fix those
bugs?

Ben.

--
Ben Hutchings
Make three consecutive correct guesses and you will be considered an expert.

Ben Hutchings, le Mon 10 Sep 2012 04:04:59 +0100, a écrit :
> But I looked at what exactly is done with this 'vars' table and... it
> looks really nasty. This goes into an initialisation string which will
> be the first thing the userland synthesiser gets when it reads the
> softsynth char device, right?

Yes.

> However:
> 1. The last character of the init string will be repeated.
> 2. If the read() caller doesn't provide a big enough buffer for the init
> string, the next read() will get it again from the start, so it can
> never make progress.

Indeed.

> Would you be able to test the attached patch, that should fix those
> bugs?

It looks and works fine for me indeed.

Samuel


--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20120911002847.GI5088@type.youpi.perso.aquilenet.f r">http://lists.debian.org/20120911002847.GI5088@type.youpi.perso.aquilenet.f r