FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Kernel

 
 
LinkBack Thread Tools
 
Old 04-04-2012, 04:28 PM
Jonathan Nieder
 
Default Bug#667501: WARNING when trying to read a floppy disk with Nautilus

reassign 667501 src:linux-2.6 3.2.12-1
tags 667501 + upstream patch moreinfo
quit

rpnpif wrote:

> WARNING: at /build/buildd-linux-2.6_3.2.12-1~bpo60+1-i386-EZ37JT/linux-2.6-3.2.12/debian/build/source_i386_none/drivers/block/floppy.c:1041 setup_rw_floppy+0x1e8/0x2a1 [floppy]()
> Hardware name: MS-6380
> floppy_disable_hlt() scheduled for removal in 2012

Thanks. This is from

commit 3b70b2e5fcf6
Author: Len Brown <len.brown@intel.com>
Date: Fri Apr 1 15:08:48 2011 -0400

x86 idle floppy: deprecate disable_hlt()

Plan to remove floppy_disable_hlt in 2012, an ancient
workaround with comments that it should be removed.

This allows us to remove clutter and a run-time branch
from the idle code.

WARN_ONCE() on invocation until it is removed.

cc: x86@kernel.org
cc: stable@kernel.org # .39.x
Signed-off-by: Len Brown <len.brown@intel.com>

Using an assertion (WARN_ONCE) means that Len thinks calls to
floppy_disable_hlt are a Bad Thing in some sense, presumably because
of their effect on power consumption. So this might be a real bug or
just an overly aggressive warning. The fix is

commit f6365201d8a2
Author: Len Brown <len.brown@intel.com>
Date: Thu Mar 29 14:49:17 2012 -0700

x86: Remove the ancient and deprecated disable_hlt() and enable_hlt() facility

and is not part of "master" yet. I don't understand how anyone
thought applying the warning without the fix could be a good idea.

Please test the attached patch, for example using the following
instructions:

0. Prerequisites.

apt-get install git build-essential

1. Get a copy of the kernel history, if you don't already have it.

git clone
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

2. Fetch point releases:

cd linux
git remote add stable
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
git fetch stable

3. Configure, build, and test:

git checkout stable/linux-3.2.y
cp /boot/config-$(uname -r) .config; # current configuration
make localmodconfig; # optional: minimize configuration
make deb-pkg; # optionally with -j<num> for parallel build
dpkg -i ../<name of package>; # as root
reboot
... test test test ...

4. Hopefully it produces the warning. So try the patch:

cd linux
git am -3sc <path to patch>
make deb-pkg; # maybe with -j4
dpkg -i ../<name of package>; # as root
reboot
... test test test ...

Hopefully it does not produce the warning.

If you happen to have a cheap and ancient 486 or Cyrix 5510, see if
floppy disk access makes the power supply go bad.

An alternative set of instructions is at [1].

Ben, I think we should take this patch. Do you think it's a candidate
for gregkh's stable tree?

Thanks,
Jonathan

[1] http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s-common-official
or the corresponding page in the debian-kernel-handbook package
 
Old 04-07-2012, 03:17 AM
Ben Hutchings
 
Default Bug#667501: WARNING when trying to read a floppy disk with Nautilus

On Wed, 2012-04-04 at 11:28 -0500, Jonathan Nieder wrote:
[...]
> Using an assertion (WARN_ONCE) means that Len thinks calls to
> floppy_disable_hlt are a Bad Thing in some sense, presumably because
> of their effect on power consumption. So this might be a real bug or
> just an overly aggressive warning. The fix is
>
> commit f6365201d8a2
> Author: Len Brown <len.brown@intel.com>
> Date: Thu Mar 29 14:49:17 2012 -0700
>
> x86: Remove the ancient and deprecated disable_hlt() and enable_hlt() facility
>
> and is not part of "master" yet. I don't understand how anyone
> thought applying the warning without the fix could be a good idea.

If this kluge had been optional in the floppy driver then warning users
that enable it might have made sense. But it seems completely useless
to warn everyone using the floppy driver.

I'm just amused that this it took 3 stable releases for someone to
complain about this. Shows how many floppies are being used today.

I don't think this explains the original report that 'Floppy drive is
unusable' though.

[...]
> Ben, I think we should take this patch. Do you think it's a candidate
> for gregkh's stable tree?

It's already on its way there.

Ben.

--
Ben Hutchings
Larkinson's Law: All laws are basically false.
 

Thread Tools




All times are GMT. The time now is 10:11 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org