Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Debian Kernel (http://www.linux-archive.org/debian-kernel/)
-   -   Bug#637240: (Solved) brcmsmac: "firmware bug" warning when connecting, hang when unloading brcmsmac driver unless near AP (http://www.linux-archive.org/debian-kernel/631578-bug-637240-solved-brcmsmac-firmware-bug-warning-when-connecting-hang-when-unloading-brcmsmac-driver-unless-near-ap.html)

Jonathan Nieder 02-11-2012 10:39 AM

Bug#637240: (Solved) brcmsmac: "firmware bug" warning when connecting, hang when unloading brcmsmac driver unless near AP
 
tags 637240 + fixed-upstream
quit

Hi,

Camaleón wrote:

> Just an update for this issue.
>
> I tried kernel 3.3-rc3 and brcmsmac has started working, it can see
> the AP regardless the netbook location and network-manager does not
> hang.

Nice.

What's the newest broken kernel version you know of? If someone
suggests versions to test or a patch to apply, would you be able to
run tests in order to help get a patch for sid (which is a 3.2.y
kernel) ready?

Thanks,
Jonathan



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20120211113938.GF3987@burratino">http://lists.debian.org/20120211113938.GF3987@burratino

Camaleón 02-11-2012 10:59 AM

Bug#637240: (Solved) brcmsmac: "firmware bug" warning when connecting, hang when unloading brcmsmac driver unless near AP
 
El 2012-02-11 a las 05:39 -0600, Jonathan Nieder escribió:

> > I tried kernel 3.3-rc3 and brcmsmac has started working, it can see
> > the AP regardless the netbook location and network-manager does not
> > hang.
>
> Nice.
>
> What's the newest broken kernel version you know of? If someone
> suggests versions to test or a patch to apply, would you be able to
> run tests in order to help get a patch for sid (which is a 3.2.y
> kernel) ready?

The last kernel I compiled and still was not working was 3.2-rc3
(from upstream kernel sources).

Yes, I can install whatever kernel version you require or run any
tests/patches you need.

My current wheezy install has Debian's stock kernel 3.1 and here I
have to use the "wl" closed source driver to get the wireless card
working :-(

Greetings,

--
Camaleón



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20120211115903.GA4977@stt008.linux.site">http://lists.debian.org/20120211115903.GA4977@stt008.linux.site

Jonathan Nieder 02-11-2012 11:08 AM

Bug#637240: (Solved) brcmsmac: "firmware bug" warning when connecting, hang when unloading brcmsmac driver unless near AP
 
Camaleón wrote:

> Yes, I can install whatever kernel version you require or run any
> tests/patches you need.

Excellent. Please test v3.2.4 from unstable. (It includes the
following patch.)

Thanks,
Jonathan

commit 4bc34a5c5c4e
Author: Stanislaw Gruszka <sgruszka@redhat.com>
Date: Tue Jan 17 12:38:50 2012 +0100

brcmsmac: fix tx queue flush infinite loop

commit f96b08a7e6f69c0f0a576554df3df5b1b519c479 upstream.

This patch workaround live deadlock problem caused by infinite loop
in brcms_c_wait_for_tx_completion(). I do not consider the patch as
the proper fix, which should fix the real reason of tx queue flush
failure, but patch helps with system lockup.

Reference:
https://bugzilla.kernel.org/show_bug.cgi?id=42576

Reported-and-tested-by: Patrick <ragamuffin@datacomm.ch>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
index 510e9bb52287..453f58e5667f 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
@@ -8217,13 +8217,21 @@ int brcms_c_get_curband(struct brcms_c_info *wlc)

void brcms_c_wait_for_tx_completion(struct brcms_c_info *wlc, bool drop)
{
+ int timeout = 20;
+
/* flush packet queue when requested */
if (drop)
brcmu_pktq_flush(&wlc->pkt_queue->q, false, NULL, NULL);

/* wait for queue and DMA fifos to run dry */
- while (!pktq_empty(&wlc->pkt_queue->q) || brcms_txpktpendtot(wlc) > 0)
+ while (!pktq_empty(&wlc->pkt_queue->q) || brcms_txpktpendtot(wlc) > 0) {
brcms_msleep(wlc->wl, 1);
+
+ if (--timeout == 0)
+ break;
+ }
+
+ WARN_ON_ONCE(timeout == 0);
}

void brcms_c_set_beacon_listen_interval(struct brcms_c_info *wlc, u8 interval)



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20120211120848.GH3987@burratino">http://lists.debian.org/20120211120848.GH3987@burratino

Camaleón 02-11-2012 02:01 PM

Bug#637240: (Solved) brcmsmac: "firmware bug" warning when connecting, hang when unloading brcmsmac driver unless near AP
 
2012/2/11 Jonathan Nieder <jrnieder@gmail.com>:
> Camaleón wrote:
>
>> Yes, I can install whatever kernel version you require or run any
>> tests/patches you need.
>
> Excellent. *Please test v3.2.4 from unstable. *(It includes the
> following patch.)
>
> Thanks,
> Jonathan
>
> commit 4bc34a5c5c4e
> Author: Stanislaw Gruszka <sgruszka@redhat.com>
> Date: * Tue Jan 17 12:38:50 2012 +0100
>
> * *brcmsmac: fix tx queue flush infinite loop
>
> * *commit f96b08a7e6f69c0f0a576554df3df5b1b519c479 upstream.

(...)

It works! :-)

root@stt300:~# uname -a
Linux stt300 3.2.0-1-686-pae #1 SMP Sun Feb 5 23:52:49 UTC 2012 i686 GNU/Linux

root@stt300:~# dpkg -l | grep -i -e linux-image-3.2
ii linux-image-3.2.0-1-686-pae 3.2.4-1
Linux 3.2 for modern PCs

root@stt300:~# cat /etc/debian_version
wheezy/sid

Greetings,

--
Camaleón



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: CAKprTDEwMO10t4N-iDLSgT+zgCpU3GA7ouvwynM3b+1MR-ZweQ@mail.gmail.com">http://lists.debian.org/CAKprTDEwMO10t4N-iDLSgT+zgCpU3GA7ouvwynM3b+1MR-ZweQ@mail.gmail.com


All times are GMT. The time now is 12:07 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.