FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Kernel

 
 
LinkBack Thread Tools
 
Old 02-09-2012, 10:55 PM
"Brian C. Lane"
 
Default don't set PMBR boot flag on EFI (#754850)

From: "Brian C. Lane" <bcl@redhat.com>

---
pyanaconda/storage/formats/disklabel.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/pyanaconda/storage/formats/disklabel.py b/pyanaconda/storage/formats/disklabel.py
index f43468a..436ee64 100644
--- a/pyanaconda/storage/formats/disklabel.py
+++ b/pyanaconda/storage/formats/disklabel.py
@@ -161,7 +161,7 @@ class DiskLabel(DeviceFormat):

# Set the boot flag on the GPT PMBR, this helps some BIOS systems boot
if self._partedDisk.isFlagAvailable(parted.DISK_GPT_P MBR_BOOT):
- if iutil.isMactel():
+ if iutil.isMactel() or iutil.isEfi():
log.debug("Not setting pmbr_boot on %s" % (self._partedDisk,))
else:
self._partedDisk.setFlag(parted.DISK_GPT_PMBR_BOOT )
--
1.7.6.5

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 02-09-2012, 11:34 PM
David Lehman
 
Default don't set PMBR boot flag on EFI (#754850)

On Thu, 2012-02-09 at 15:55 -0800, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl@redhat.com>
>
> ---
> pyanaconda/storage/formats/disklabel.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

I'd guess isMactel implies isEfi but, either way, ack.

>
> diff --git a/pyanaconda/storage/formats/disklabel.py b/pyanaconda/storage/formats/disklabel.py
> index f43468a..436ee64 100644
> --- a/pyanaconda/storage/formats/disklabel.py
> +++ b/pyanaconda/storage/formats/disklabel.py
> @@ -161,7 +161,7 @@ class DiskLabel(DeviceFormat):
>
> # Set the boot flag on the GPT PMBR, this helps some BIOS systems boot
> if self._partedDisk.isFlagAvailable(parted.DISK_GPT_P MBR_BOOT):
> - if iutil.isMactel():
> + if iutil.isMactel() or iutil.isEfi():
> log.debug("Not setting pmbr_boot on %s" % (self._partedDisk,))
> else:
> self._partedDisk.setFlag(parted.DISK_GPT_PMBR_BOOT )


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 02-10-2012, 12:41 AM
"Brian C. Lane"
 
Default don't set PMBR boot flag on EFI (#754850)

On Thu, Feb 09, 2012 at 06:34:07PM -0600, David Lehman wrote:
> On Thu, 2012-02-09 at 15:55 -0800, Brian C. Lane wrote:
> > From: "Brian C. Lane" <bcl@redhat.com>
> >
> > ---
> > pyanaconda/storage/formats/disklabel.py | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> I'd guess isMactel implies isEfi but, either way, ack.
>

Good point. pushed with just isEfi()

--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 10:43 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org