Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Debian Kernel (http://www.linux-archive.org/debian-kernel/)
-   -   Bug#654206: ext4: Report max_batch_time option correctly (http://www.linux-archive.org/debian-kernel/616132-bug-654206-ext4-report-max_batch_time-option-correctly.html)

Ben Hutchings 01-02-2012 01:13 PM

Bug#654206: ext4: Report max_batch_time option correctly
 
Currently the value reported for max_batch_time is really the
value of min_batch_time.

Reported-by: Russell Coker <russell@coker.com.au>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
fs/ext4/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 3e1329e..410e993 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1096,7 +1096,7 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs)
}
if (sbi->s_max_batch_time != EXT4_DEF_MAX_BATCH_TIME) {
seq_printf(seq, ",max_batch_time=%u",
- (unsigned) sbi->s_min_batch_time);
+ (unsigned) sbi->s_max_batch_time);
}

/*
--
1.7.7.3

Eric Sandeen 01-03-2012 02:46 PM

Bug#654206: ext4: Report max_batch_time option correctly
 
On 1/2/12 8:13 AM, Ben Hutchings wrote:
> Currently the value reported for max_batch_time is really the
> value of min_batch_time.
>
> Reported-by: Russell Coker <russell@coker.com.au>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

whoops, yep!

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
> fs/ext4/super.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 3e1329e..410e993 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1096,7 +1096,7 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs)
> }
> if (sbi->s_max_batch_time != EXT4_DEF_MAX_BATCH_TIME) {
> seq_printf(seq, ",max_batch_time=%u",
> - (unsigned) sbi->s_min_batch_time);
> + (unsigned) sbi->s_max_batch_time);
> }
>
> /*




--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 4F0322D0.2070403@redhat.com">http://lists.debian.org/4F0322D0.2070403@redhat.com

Ted Ts'o 01-05-2012 01:23 AM

Bug#654206: ext4: Report max_batch_time option correctly
 
On Mon, Jan 02, 2012 at 02:13:02PM +0000, Ben Hutchings wrote:
> Currently the value reported for max_batch_time is really the
> value of min_batch_time.
>
> Reported-by: Russell Coker <russell@coker.com.au>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

Applied, thanks.

- Ted



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20120105022310.GA24494@thunk.org">http://lists.debian.org/20120105022310.GA24494@thunk.org


All times are GMT. The time now is 12:06 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.