Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Debian Kernel (http://www.linux-archive.org/debian-kernel/)
-   -   grubby: linking to glib-2.0 (http://www.linux-archive.org/debian-kernel/598297-grubby-linking-glib-2-0-a.html)

Cleber Rosa 11-14-2011 02:08 PM

grubby: linking to glib-2.0
 
Hi,

I've noticed that grubby's Makefile links to glib-2.0, but it does not
seem to be needed at all:


# git diff
diff --git a/Makefile b/Makefile
index f13f330..8b188f1 100644
--- a/Makefile
+++ b/Makefile
@@ -27,7 +27,6 @@ CFLAGS += $(RPM_OPT_FLAGS) -std=gnu99 -Wall -Werror
-Wno-error=unused-function -

LDFLAGS :=

grubby_LIBS = -lblkid -lpopt
-grubby_LIBS += $(shell pkg-config --libs glib-2.0)

all: grubby


# make
gcc -std=gnu99 -Wall -Werror -Wno-error=unused-function
-Wno-unused-function -ggdb -DVERSION='"8.3"' -c -o grubby.o grubby.c
gcc -std=gnu99 -Wall -Werror -Wno-error=unused-function
-Wno-unused-function -ggdb -o grubby grubby.o -lblkid -lpopt



Any not-so-obvious reasons for that? Care for a formal patch?

Cheers.
CR.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Lucas Meneghel Rodrigues 11-16-2011 09:50 PM

grubby: linking to glib-2.0
 
On 11/14/2011 01:08 PM, Cleber Rosa wrote:

Hi,

I've noticed that grubby's Makefile links to glib-2.0, but it does not
seem to be needed at all:


ping?


# git diff
diff --git a/Makefile b/Makefile
index f13f330..8b188f1 100644
--- a/Makefile
+++ b/Makefile
@@ -27,7 +27,6 @@ CFLAGS += $(RPM_OPT_FLAGS) -std=gnu99 -Wall -Werror
-Wno-error=unused-function -
LDFLAGS :=

grubby_LIBS = -lblkid -lpopt
-grubby_LIBS += $(shell pkg-config --libs glib-2.0)

all: grubby


# make
gcc -std=gnu99 -Wall -Werror -Wno-error=unused-function
-Wno-unused-function -ggdb -DVERSION='"8.3"' -c -o grubby.o grubby.c
gcc -std=gnu99 -Wall -Werror -Wno-error=unused-function
-Wno-unused-function -ggdb -o grubby grubby.o -lblkid -lpopt


Any not-so-obvious reasons for that? Care for a formal patch?

Cheers.
CR.


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Chris Lumens 11-16-2011 10:03 PM

grubby: linking to glib-2.0
 
> Any not-so-obvious reasons for that? Care for a formal patch?

I see no reason for grubby to use glib. pjones or bcl would be happy to
apply a patch, I am sure.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 12:29 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.