FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Kernel

 
 
LinkBack Thread Tools
 
Old 09-01-2011, 04:56 PM
David Cantrell
 
Default Single quote values in show_parms() in linuxrc.s390 (#681219)

---
loader2/linuxrc.s390 | 34 +++++++++++++++++-----------------
1 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/loader2/linuxrc.s390 b/loader2/linuxrc.s390
index 39b93d8..2732270 100644
--- a/loader2/linuxrc.s390
+++ b/loader2/linuxrc.s390
@@ -2638,28 +2638,28 @@ function show_parms() {
# For the time being, at least the parameters LAYER2, PORTNAME, and CTCPROT
# only get asked on being empty if not running in kickstart mode.
cat << EOF
-NETTYPE=$NETTYPE
-IPADDR=$IPADDR
-NETMASK=$NETMASK
-GATEWAY=$GATEWAY
-HOSTNAME=$HOSTNAME
+NETTYPE='$NETTYPE'
+IPADDR='$IPADDR'
+NETMASK='$NETMASK'
+GATEWAY='$GATEWAY'
+HOSTNAME='$HOSTNAME'
EOF
- [ "$SUBCHANNELS" ] && echo "SUBCHANNELS=$SUBCHANNELS"
- [ "$LAYER2" ] && echo "LAYER2=$LAYER2"
- [ "$VSWITCH" ] && echo "VSWITCH=$VSWITCH"
- [ "$MACADDR" ] && echo "MACADDR=$MACADDR"
- [ "$PORTNAME" ] && echo "PORTNAME=$PORTNAME"
- [ "$PORTNO" ] && echo "PORTNO=$PORTNO"
- [ "$PEERID" ] && echo "PEERID=$PEERID"
- [ "$CTCPROT" ] && echo "CTCPROT=$CTCPROT"
+ [ "$SUBCHANNELS" ] && echo "SUBCHANNELS='$SUBCHANNELS'"
+ [ "$LAYER2" ] && echo "LAYER2='$LAYER2'"
+ [ "$VSWITCH" ] && echo "VSWITCH='$VSWITCH'"
+ [ "$MACADDR" ] && echo "MACADDR='$MACADDR'"
+ [ "$PORTNAME" ] && echo "PORTNAME='$PORTNAME'"
+ [ "$PORTNO" ] && echo "PORTNO='$PORTNO'"
+ [ "$PEERID" ] && echo "PEERID='$PEERID'"
+ [ "$CTCPROT" ] && echo "CTCPROT='$CTCPROT'"
if [ -n "$mmtu_was_set" ]; then
echo "MMTU="$MMTU""
elif [ -n "$mtu_was_set" ]; then
- echo "MTU=$MTU"
+ echo "MTU='$MTU'"
fi
- [ "$DNS" ] && echo "DNS=$DNS"
- [ "$SEARCHDNS" ] && echo "SEARCHDNS=$SEARCHDNS"
- [ "$DASD" ] && echo "DASD=$DASD"
+ [ "$DNS" ] && echo "DNS='$DNS'"
+ [ "$SEARCHDNS" ] && echo "SEARCHDNS='$SEARCHDNS'"
+ [ "$DASD" ] && echo "DASD='$DASD'"
}

function final_check() {
--
1.7.1

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 09-01-2011, 11:26 PM
"Brian C. Lane"
 
Default Single quote values in show_parms() in linuxrc.s390 (#681219)

On Thu, Sep 01, 2011 at 12:56:04PM -0400, David Cantrell wrote:

> + [ "$PEERID" ] && echo "PEERID='$PEERID'"
> + [ "$CTCPROT" ] && echo "CTCPROT='$CTCPROT'"
> if [ -n "$mmtu_was_set" ]; then
> echo "MMTU="$MMTU""

Any particular reason why this is double quoted instead of single? Seems
like a good time to make it consistent.

--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 04:16 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org