Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Debian Kernel (http://www.linux-archive.org/debian-kernel/)
-   -   Bug#633595: elantech mouse v3 support (http://www.linux-archive.org/debian-kernel/569556-bug-633595-elantech-mouse-v3-support.html)

Ben Hutchings 08-29-2011 03:22 PM

Bug#633595: elantech mouse v3 support
 
On Mon, 2011-08-29 at 16:06 +0200, Julien Valroff wrote:
> Hi Ben,
>
> Le lundi 29 août 2011 à 14:07:44 (+0200 CEST), Ben Hutchings a écrit :
> > On Mon, 2011-08-29 at 00:35 +0200, Eloi COUTANT wrote:
> > > Hi.
> > >
> > > I confirm that Julien's patch is efficient on Samsung RC510.
> > > I have no problems anymore : one, two and three fingers are working,
> > > "wheels" too !
> > [...]
> >
> > Julien, please can you provide a list of *upstream* changes. We will
> > not apply a large patch with no such references.
>
> I have not written that patch at all, just made available the "original"
> DKMS tree so that people can test it easily.
>
> The patch was written by Seth Forshee <seth.forshee@canonical.com> and is
> available on LaunchPad bug #681904 [0].
>
> All the patches, Ubuntu builts and dkms .deb are available at:
> http://people.canonical.com/~sforshee/lp681904/

OK, so I see this patch:
http://people.canonical.com/~sforshee/lp681904/linux-3.0.0-8.10~lp681904v201108052055/0001-Input-elantech-Add-v3-hardware-support.patch
which looks like something that could go upstream. But it hasn't, or at
least it's not visible in linux-next.

Ben.

Seth Forshee 08-29-2011 03:56 PM

Bug#633595: elantech mouse v3 support
 
On Mon, Aug 29, 2011 at 04:22:36PM +0100, Ben Hutchings wrote:
> On Mon, 2011-08-29 at 16:06 +0200, Julien Valroff wrote:
> > Hi Ben,
> >
> > Le lundi 29 août 2011 à 14:07:44 (+0200 CEST), Ben Hutchings a écrit :
> > > On Mon, 2011-08-29 at 00:35 +0200, Eloi COUTANT wrote:
> > > > Hi.
> > > >
> > > > I confirm that Julien's patch is efficient on Samsung RC510.
> > > > I have no problems anymore : one, two and three fingers are working,
> > > > "wheels" too !
> > > [...]
> > >
> > > Julien, please can you provide a list of *upstream* changes. We will
> > > not apply a large patch with no such references.
> >
> > I have not written that patch at all, just made available the "original"
> > DKMS tree so that people can test it easily.
> >
> > The patch was written by Seth Forshee <seth.forshee@canonical.com> and is
> > available on LaunchPad bug #681904 [0].
> >
> > All the patches, Ubuntu builts and dkms .deb are available at:
> > http://people.canonical.com/~sforshee/lp681904/
>
> OK, so I see this patch:
> http://people.canonical.com/~sforshee/lp681904/linux-3.0.0-8.10~lp681904v201108052055/0001-Input-elantech-Add-v3-hardware-support.patch
> which looks like something that could go upstream. But it hasn't, or at
> least it's not visible in linux-next.

That patch will not be going upstream. Elantech has submitted more
comprehensive updates to the driver that were developed in parallel (see
https://lkml.org/lkml/2011/8/29/63 for the most recent revision).

We are carrying an updated version of the above patch temporarily until
Elantech's solution makes it upstream. In practice that probably means
we'll use my patch for Ubuntu 11.10 and switch to Elantech's solution in
12.04. The advantage to the patch we're carrying now versus Elantech's
is that it doesn't functionally modify the v1 or v2 touchpad support,
and thus shouldn't carry any risk of regression for those devices. I've
attached a copy of the updated patch.

Cheers,
Seth

Ben Hutchings 09-06-2011 04:43 AM

Bug#633595: elantech mouse v3 support
 
On Mon, 2011-08-29 at 10:56 -0500, Seth Forshee wrote:
> On Mon, Aug 29, 2011 at 04:22:36PM +0100, Ben Hutchings wrote:
> > On Mon, 2011-08-29 at 16:06 +0200, Julien Valroff wrote:
> > > Hi Ben,
> > >
> > > Le lundi 29 août 2011 à 14:07:44 (+0200 CEST), Ben Hutchings a écrit :
> > > > On Mon, 2011-08-29 at 00:35 +0200, Eloi COUTANT wrote:
> > > > > Hi.
> > > > >
> > > > > I confirm that Julien's patch is efficient on Samsung RC510.
> > > > > I have no problems anymore : one, two and three fingers are working,
> > > > > "wheels" too !
> > > > [...]
> > > >
> > > > Julien, please can you provide a list of *upstream* changes. We will
> > > > not apply a large patch with no such references.
> > >
> > > I have not written that patch at all, just made available the "original"
> > > DKMS tree so that people can test it easily.
> > >
> > > The patch was written by Seth Forshee <seth.forshee@canonical.com> and is
> > > available on LaunchPad bug #681904 [0].
> > >
> > > All the patches, Ubuntu builts and dkms .deb are available at:
> > > http://people.canonical.com/~sforshee/lp681904/
> >
> > OK, so I see this patch:
> > http://people.canonical.com/~sforshee/lp681904/linux-3.0.0-8.10~lp681904v201108052055/0001-Input-elantech-Add-v3-hardware-support.patch
> > which looks like something that could go upstream. But it hasn't, or at
> > least it's not visible in linux-next.
>
> That patch will not be going upstream. Elantech has submitted more
> comprehensive updates to the driver that were developed in parallel (see
> https://lkml.org/lkml/2011/8/29/63 for the most recent revision).
>
> We are carrying an updated version of the above patch temporarily until
> Elantech's solution makes it upstream. In practice that probably means
> we'll use my patch for Ubuntu 11.10 and switch to Elantech's solution in
> 12.04. The advantage to the patch we're carrying now versus Elantech's
> is that it doesn't functionally modify the v1 or v2 touchpad support,
> and thus shouldn't carry any risk of regression for those devices. I've
> attached a copy of the updated patch.

Thanks, but I think we'll wait for the official version.

Ben.


All times are GMT. The time now is 09:23 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.