FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Debian > Debian Kernel

 
 
LinkBack Thread Tools
 
Old 08-17-2011, 12:50 PM
Radek Vykydal
 
Default Fix parsing of network kickstart command (#731274)

From: Masahiro Matsuya <mmatsuya@redhat.com>

In some kickstart command orderings (e.g. "network" preceding "url"
command) network command is ignored.

A regression, patch tested.
---
loader/kickstart.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/loader/kickstart.c b/loader/kickstart.c
index 3007f86..0429d9d 100644
--- a/loader/kickstart.c
+++ b/loader/kickstart.c
@@ -561,6 +561,7 @@ void runKickstart(struct loaderData_s * loaderData) {
logMessage(INFO, "setting up kickstart");
for (cmd = ksTable; cmd->name; cmd++) {
if (!strcmp(cmd->name, "network")) {
+ argv = NULL;
while ((!ksGetCommand(cmd->code, argv, &argc, &argv)) && cmd->setupData) {
cmd->setupData(loaderData, argc, argv);
}
--
1.7.4

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 08-17-2011, 12:54 PM
Radek Vykydal
 
Default Fix parsing of network kickstart command (#731274)

The patch looks good.

On 08/17/2011 02:50 PM, Radek Vykydal wrote:

From: Masahiro Matsuya<mmatsuya@redhat.com>

In some kickstart command orderings (e.g. "network" preceding "url"
command) network command is ignored.

A regression, patch tested.
---
loader/kickstart.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/loader/kickstart.c b/loader/kickstart.c
index 3007f86..0429d9d 100644
--- a/loader/kickstart.c
+++ b/loader/kickstart.c
@@ -561,6 +561,7 @@ void runKickstart(struct loaderData_s * loaderData) {
logMessage(INFO, "setting up kickstart");
for (cmd = ksTable; cmd->name; cmd++) {
if (!strcmp(cmd->name, "network")) {
+ argv = NULL;
while ((!ksGetCommand(cmd->code, argv,&argc,&argv))&& cmd->setupData) {
cmd->setupData(loaderData, argc, argv);
}


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 12:33 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org