On Mon, 11 Apr 2011, Timo Juhani Lindfors wrote:

> maximilian attems <max@stro.at> writes:
> >> +try_modprobe()
> > I'd prefer the function to be named modprobe_verbose()
>
> Ok.
>
> >> + try_modprobe atkbd
> > why not using "-v" from modprobe,
> > the only argument against that would count is busybox support.
> > please check?
>
> I'm not very familiar with busybox internals but at least on squeeze I
> don't even have the modprobe applet:

I checked busybox source, it does support the verbose -v switch.
so changing your function in the patch, looks good.

now the only thing that is holding me up to merge your patch is that
/proc/bus/input/devices usage, there should be some sysfs file, no?


cat /sys/class/input/input*/device/description shows a KBD

--
maks



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20110516123325.GA31943@stro.at">http://lists.debian.org/20110516123325.GA31943@stro.at

maximilian attems <max@stro.at> writes:
> now the only thing that is holding me up to merge your patch is that
> /proc/bus/input/devices usage, there should be some sysfs file, no?
>
>
> cat /sys/class/input/input*/device/description shows a KBD

Unfortunately it does not show a keyboard here:

root@metunconf:~# cat /sys/class/input/input*/device/description
cat: /sys/class/input/input*/device/description: No such file or directory
root@metunconf:~# find /sys/class/input
/sys/class/input
/sys/class/input/input0
/sys/class/input/mice
/sys/class/input/mouse0
/sys/class/input/input1
/sys/class/input/input2
/sys/class/input/mouse1
/sys/class/input/input3
/sys/class/input/input4
/sys/class/input/mouse2
/sys/class/input/input5
/sys/class/input/mouse3
/sys/class/input/input6
/sys/class/input/input7
/sys/class/input/event0
/sys/class/input/event1
/sys/class/input/event2
/sys/class/input/event3
/sys/class/input/event4
/sys/class/input/event5
/sys/class/input/event6
/sys/class/input/event7
/sys/class/input/input8
/sys/class/input/event8
/sys/class/input/js0
root@metunconf:~# lsusb
Bus 006 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 004 Device 002: ID 0624:0248 Avocent Corp.
Bus 004 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 002: ID 04d9:1400 Holtek Semiconductor, Inc. PS/2 keyboard + mouse controller
Bus 001 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
root@metunconf:~# cat /proc/bus/input/devices
I: Bus=0017 Vendor=0001 Product=0001 Version=0100
N: Name="Macintosh mouse button emulation"
P: Phys=
S: Sysfs=/devices/virtual/input/input0
U: Uniq=
H: Handlers=mouse0 event0
B: EV=7
B: KEY=70000 0 0 0 0
B: REL=3

I: Bus=0003 Vendor=04d9 Product=1400 Version=0110
N: Name="HID 04d9:1400"
P: Phys=usb-0000:00:12.0-5/input0
S: Sysfs=/devices/pci0000:00/0000:00:12.0/usb1/1-5/1-5:1.0/input/input1
U: Uniq=
H: Handlers=kbd event1
B: EV=120013
B: KEY=1000000000007 ff9f207ac14057ff febeffdfffefffff fffffffffffffffe
B: MSC=10
B: LED=7

I: Bus=0003 Vendor=04d9 Product=1400 Version=0110
N: Name="HID 04d9:1400"
P: Phys=usb-0000:00:12.0-5/input1
S: Sysfs=/devices/pci0000:00/0000:00:12.0/usb1/1-5/1-5:1.1/input/input2
U: Uniq=
H: Handlers=kbd mouse1 event2
B: EV=17
B: KEY=1f0000 2000000 39fad941d001 1e000000000000 0
B: REL=103
B: MSC=10

I: Bus=0003 Vendor=0624 Product=0248 Version=0100
N: Name="Avocent USB Composite Device-0"
P: Phys=usb-0000:00:13.2-2/input0
S: Sysfs=/devices/pci0000:00/0000:00:13.2/usb4/4-2/4-2:1.0/input/input3
U: Uniq=20090730
H: Handlers=kbd event3
B: EV=120013
B: KEY=1000000000007 ff9f207ac14057ff febeffdfffefffff fffffffffffffffe
B: MSC=10
B: LED=1f

I: Bus=0003 Vendor=0624 Product=0248 Version=0100
N: Name="Avocent USB Composite Device-0"
P: Phys=usb-0000:00:13.2-2/input1
S: Sysfs=/devices/pci0000:00/0000:00:13.2/usb4/4-2/4-2:1.1/input/input4
U: Uniq=20090730
H: Handlers=mouse2 event4 js0
B: EV=1f
B: KEY=70000 0 0 0 0
B: REL=100
B: ABS=3
B: MSC=10

I: Bus=0003 Vendor=0624 Product=0248 Version=0100
N: Name="Avocent USB Composite Device-0"
P: Phys=usb-0000:00:13.2-2/input2
S: Sysfs=/devices/pci0000:00/0000:00:13.2/usb4/4-2/4-2:1.2/input/input5
U: Uniq=20090730
H: Handlers=mouse3 event5
B: EV=17
B: KEY=70000 0 0 0 0
B: REL=103
B: MSC=10

I: Bus=0019 Vendor=0000 Product=0001 Version=0000
N: Name="Power Button"
P: Phys=PNP0C0C/button/input0
S: Sysfs=/devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0C:00/input/input6
U: Uniq=
H: Handlers=kbd event6
B: EV=3
B: KEY=10000000000000 0

I: Bus=0019 Vendor=0000 Product=0001 Version=0000
N: Name="Power Button"
P: Phys=LNXPWRBN/button/input0
S: Sysfs=/devices/LNXSYSTM:00/LNXPWRBN:00/input/input7
U: Uniq=
H: Handlers=kbd event7
B: EV=3
B: KEY=10000000000000 0

I: Bus=0010 Vendor=001f Product=0001 Version=0100
N: Name="PC Speaker"
P: Phys=isa0061/input0
S: Sysfs=/devices/platform/pcspkr/input/input8
U: Uniq=
H: Handlers=kbd event8
B: EV=40001
B: SND=6

root@metunconf:~# dmesg | head -n4
[ 0.000000] Initializing cgroup subsys cpuset
[ 0.000000] Initializing cgroup subsys cpu
[ 0.000000] Linux version 2.6.32-5-amd64 (Debian 2.6.32-30) (ben@decadent.org.uk) (gcc version 4.3.5 (Debian 4.3.5-4) ) #1 SMP Wed Jan 12 03:40:32 UTC 2011
[ 0.000000] Command line: root=/dev/nfs initrd=squeeze64unconf/initrd.img nfsroot=10.8.8.8:/tftpboot/squeeze64unconf ip=dhcp BOOT_IMAGE=squeeze64unconf/vmlinuz

As a test I did

root@metunconf:~# rmmod usbhid
root@metunconf:~# rmmod hid

and verified that I can no longer type anything to the console.




--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 84vcwrtk4w.fsf@sauna.l.org">http://lists.debian.org/84vcwrtk4w.fsf@sauna.l.org

On Tue, May 31, 2011 at 10:16:31AM +0300, Timo Juhani Lindfors wrote:
> maximilian attems <max@stro.at> writes:
> > now the only thing that is holding me up to merge your patch is that
> > /proc/bus/input/devices usage, there should be some sysfs file, no?
> >
> >
> > cat /sys/class/input/input*/device/description shows a KBD
>
> Unfortunately it does not show a keyboard here:
>
> root@metunconf:~# cat /sys/class/input/input*/device/description
> cat: /sys/class/input/input*/device/description: No such file or directory

yep that is the case for usb keyboard, so you can check no existence of that.

--
maks



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20110531090058.GD18343@vostochny.stro.at">http://lists.debian.org/20110531090058.GD18343@vostochny.stro.at

Hi,

maximilian attems <max@stro.at> writes:
>> cat: /sys/class/input/input*/device/description: No such file or directory
>
> yep that is the case for usb keyboard, so you can check no existence of that.

aha, good idea. I'll send new patches against git HEAD.

I built these with git-buildpackage and tested them again on the same HP
ProLiant MicroServer.

-Timo




--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 8462oq82vg.fsf@sauna.l.org">http://lists.debian.org/8462oq82vg.fsf@sauna.l.org