Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Debian Kernel (http://www.linux-archive.org/debian-kernel/)
-   -   Bug#624692: suggested patch (http://www.linux-archive.org/debian-kernel/520444-bug-624692-suggested-patch.html)

maximilian attems 04-30-2011 07:41 PM

Bug#624692: suggested patch
 
which module-init-tools do you use?

and why not emmit the warning there properly.
to have that fixed for dractu too.

thanks

--
maks



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20110430194103.GF12372@vostochny.stro.at">http://lists.debian.org/20110430194103.GF12372@vostochny.stro.at

Alexander Wuerstlein 04-30-2011 08:34 PM

Bug#624692: suggested patch
 
On 11-04-30 21:41, maximilian attems <maks@debian.org> wrote:
> which module-init-tools do you use?

3.12-1

> and why not emmit the warning there properly.
> to have that fixed for dractu too.

Yes, that would be possible, too, but:

modprobe emits an error that is suppressed by the --quiet parameter:
| # modprobe --set-version="2.6.32.39" --ignore-install --show-depends r8168
| FATAL: Module r8168 not found.

Problem is that this warning is not very helpful since the module does
indeed exists, just modules.dep does not contain a reference to it. So
if modprobe were to emit a proper warning (like "Module r8168 not found
in modules.dep, try depmod -a $version") , the --quiet would still have
to be removed from the call to modprobe.



Ciao,

Alexander Wuerstlein.



--
To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: 20110430203453.GN27010@cip.informatik.uni-erlangen.de">http://lists.debian.org/20110430203453.GN27010@cip.informatik.uni-erlangen.de

Ben Hutchings 04-30-2011 08:56 PM

Bug#624692: suggested patch
 
On Sat, 2011-04-30 at 22:34 +0200, Alexander Wuerstlein wrote:
> On 11-04-30 21:41, maximilian attems <maks@debian.org> wrote:
> > which module-init-tools do you use?
>
> 3.12-1
>
> > and why not emmit the warning there properly.
> > to have that fixed for dractu too.
>
> Yes, that would be possible, too, but:
>
> modprobe emits an error that is suppressed by the --quiet parameter:
> | # modprobe --set-version="2.6.32.39" --ignore-install --show-depends r8168
> | FATAL: Module r8168 not found.
>
> Problem is that this warning is not very helpful since the module does
> indeed exists, just modules.dep does not contain a reference to it.
[...]

I think the current error message in modprobe is fine; it is not the job
of modprobe to provide a tutorial on how to install modules.

I think mkinitramfs should warn about any module that can't be found by
modprobe, but there may be some exceptions where we want the quiet
behaviour.

Ben.

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.


All times are GMT. The time now is 09:34 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.